Stop using emberAfSendImmediateDefaultResponse. #25064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was generated by installing the git-extras package and running the following commands: git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_INVALID_COMMAND);' 'commandObj->AddStatus(commandPath, Status::InvalidCommand);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_SUCCESS);' 'commandObj->AddStatus(commandPath, Status::Success);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_FAILURE);' 'commandObj->AddStatus(commandPath, Status::Failure);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_UNSUPPORTED_COMMAND);' 'commandObj->AddStatus(commandPath, Status::UnsupportedCommand);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_MALFORMED_COMMAND);' 'commandObj->AddStatus(commandPath, Status::InvalidAction);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_CONSTRAINT_ERROR);' 'commandObj->AddStatus(commandPath, Status::ConstraintError);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_NOT_FOUND);' 'commandObj->AddStatus(commandPath, Status::NotFound);'
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
msandstedt,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
tcarmelveilleux
approved these changes
Feb 14, 2023
|
PR #25064: Size comparison from a6d2883 to 01f9682 Increases above 0.2%:
Increases (37 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (19 builds for bl702, cc13x2_26x2, cc32xx, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
approved these changes
Feb 15, 2023
auto-merge was automatically disabled
February 15, 2023 14:43
Merge commits are not allowed on this repository
|
@bzbarsky-apple In the commit: 7990de5, there are errors in groups-client.cpp, identify-client.cpp and scene-client.cpp. The function "commandObj->AddStatus(commandPath, Status::Success);" calling use an undefined variable "commandPath", so if you build this three file, it will raise a build error. |
|
That function would never actually be called, for what it's worth. Those files are not compiled by anything in-tree, and they don't really work right if they were @Jerry-ESP. |
|
@Jerry-ESP #25493 removes those files. |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Stop using emberAfSendImmediateDefaultResponse. This commit was generated by installing the git-extras package and running the following commands: git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_INVALID_COMMAND);' 'commandObj->AddStatus(commandPath, Status::InvalidCommand);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_SUCCESS);' 'commandObj->AddStatus(commandPath, Status::Success);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_FAILURE);' 'commandObj->AddStatus(commandPath, Status::Failure);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_UNSUPPORTED_COMMAND);' 'commandObj->AddStatus(commandPath, Status::UnsupportedCommand);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_MALFORMED_COMMAND);' 'commandObj->AddStatus(commandPath, Status::InvalidAction);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_CONSTRAINT_ERROR);' 'commandObj->AddStatus(commandPath, Status::ConstraintError);' git sed 'emberAfSendImmediateDefaultResponse(EMBER_ZCL_STATUS_NOT_FOUND);' 'commandObj->AddStatus(commandPath, Status::NotFound);' * Manual changes to make the mass-replaces compile. * Manual changes to remove emberAfSendImmediateDefaultResponse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: This PR consists of three commits: