-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add an optional definition property to pseudo clus… #25061
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YamlTests_PseudoClusterDefinitions
Feb 16, 2023
Merged
[matter_yamltests] Add an optional definition property to pseudo clus… #25061
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YamlTests_PseudoClusterDefinitions
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 14, 2023 18:52
pullapprove
bot
requested review from
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 14, 2023 18:52
PR #25061: Size comparison from a6d2883 to 9966211 Full report (5 builds for cc32xx, linux, qpg)
|
tehampson
approved these changes
Feb 15, 2023
scripts/py_matter_yamltests/matter_yamltests/pseudo_clusters/pseudo_cluster.py
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
February 15, 2023 13:42
Merge queue setting changed
…ter in order to benefits from the built-in error reporting
vivien-apple
force-pushed
the
YamlTests_PseudoClusterDefinitions
branch
from
February 15, 2023 17:33
9966211
to
8fa74e4
Compare
PR #25061: Size comparison from 9524caf to 8fa74e4 Increases (2 builds for cc32xx, nrfconnect)
Decreases (8 builds for bl702, esp32, k32w, psoc6, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
Feb 16, 2023
scripts/py_matter_yamltests/matter_yamltests/pseudo_clusters/pseudo_cluster.py
Outdated
Show resolved
Hide resolved
PR #25061: Size comparison from 9524caf to 54236d6 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ter in order to benefits from the built-in error reporting (project-chip#25061)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ter in order to benefits from the built-in error reporting
Problem
The pseudo-clusters does not benefits from the built in error reporting and those can fails at runtime instead of parse time.
This PR adds an optional definition property to the pseudo cluster base class such that one can register a definition with the expected commands/arguments/responses.
With this is someone mistyped a command or an argument name it will fails at parsing not runtime. It also offers some guarantees to the pseudo clusters implementation where you don't have to validates the input.