Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused LevelControl.cpp file. #25060

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Remove unused LevelControl.cpp file. #25060

merged 1 commit into from
Feb 15, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

The file wouldn't even compile at this point, so it's a good thing it's unused.

@bzbarsky-apple
Remove unused LevelControl.cpp file.
1804846 
The file wouldn't even compile at this point, so it's a good thing it's unused.
@jmartinez-silabs jmartinez-silabs enabled auto-merge (squash) February 14, 2023 17:40
@pullapprove pullapprove bot requested a review from kkasperczyk-no February 14, 2023 18:09
@woody-apple woody-apple disabled auto-merge February 14, 2023 18:43
@github-actions
Copy link

PR #25060: Size comparison from 59a4de4 to 1804846

Increases (6 builds for cc13x2_26x2, cc32xx, esp32, psoc6, telink)
platform target config section 59a4de4 1804846 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 160956 160964 8 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20250999 20251000 1 0.0
esp32 all-clusters-app c3devkit (read only) 1047830 1047832 2 0.0
.flash.text 1047830 1047832 2 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27511958 27511959 1 0.0
light cy8ckit_062s2_43012 .debug_info 22852091 22852092 1 0.0
telink thermostat tlsr9518adk80d (read/write) 874872 874880 8 0.0
text 593444 593448 4 0.0
Decreases (9 builds for cc13x2_26x2, efr32, esp32, psoc6, telink)
platform target config section 59a4de4 1804846 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 642187 642179 -8 -0.0
.text 563672 563664 -8 -0.0
pump-app LP_CC2652R7 (read only) 688315 688307 -8 -0.0
.text 597008 597000 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1066376 1066368 -8 -0.0
.text 911204 911196 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 501347 501343 -4 -0.0
.flash.rodata 250488 250484 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27964480 27964479 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23081985 23081984 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 684646 684644 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 950060 950052 -8 -0.0
text 646920 646916 -4 -0.0
lighting-app tlsr9518adk80d text 657266 657264 -2 -0.0
Full report (36 builds for cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section 59a4de4 1804846 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678363 678363 0 0.0
(read/write) 172820 172820 0 0.0
.bss 80876 80876 0 0.0
.data 3384 3384 0 0.0
.rodata 88403 88403 0 0.0
.text 589644 589644 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642187 642179 -8 -0.0
(read/write) 157568 157568 0 0.0
.bss 80068 80068 0 0.0
.data 3384 3384 0 0.0
.rodata 78195 78195 0 0.0
.text 563672 563664 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 675255 675255 0 0.0
(read/write) 173280 173280 0 0.0
.bss 78316 78316 0 0.0
.data 3312 3312 0 0.0
.rodata 76703 76703 0 0.0
.text 598072 598072 0 0.0
lock-mtd LP_CC2652R7 (read only) 661675 661675 0 0.0
(read/write) 182116 182116 0 0.0
.bss 73572 73572 0 0.0
.data 3312 3312 0 0.0
.rodata 103291 103291 0 0.0
.text 557904 557904 0 0.0
pump-app LP_CC2652R7 (read only) 688315 688307 -8 -0.0
(read/write) 160956 160964 8 0.0
.bss 78284 78284 0 0.0
.data 3276 3276 0 0.0
.rodata 90827 90827 0 0.0
.text 597008 597000 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 673691 673691 0 0.0
(read/write) 175692 175692 0 0.0
.bss 78396 78396 0 0.0
.data 3300 3300 0 0.0
.rodata 86867 86867 0 0.0
.text 586344 586344 0 0.0
shell LP_CC2652R7 (read only) 669634 669634 0 0.0
(read/write) 183620 183620 0 0.0
.bss 82948 82948 0 0.0
.data 3380 3380 0 0.0
.rodata 85154 85154 0 0.0
.text 584168 584168 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640545 640545 0 0.0
(read/write) 204092 204092 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197496 197496 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 929366 929366 0 0.0
.debug_aranges 87360 87360 0 0.0
.debug_frame 299868 299868 0 0.0
.debug_info 20250999 20251000 1 0.0
.debug_line 2652227 2652227 0 0.0
.debug_loc 2786303 2786303 0 0.0
.debug_ranges 280856 280856 0 0.0
.debug_str 3005403 3005403 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105665 105665 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375952 375952 0 0.0
.symtab 255888 255888 0 0.0
.text 532760 532760 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584974 584974 0 0.0
.app_xip_area 461768 461768 0 0.0
.bss 65648 65648 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588946 588946 0 0.0
.app_xip_area 460444 460444 0 0.0
.bss 70936 70936 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550170 550170 0 0.0
.app_xip_area 432468 432468 0 0.0
.bss 60192 60192 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1038776 1038776 0 0.0
.bss 181576 181576 0 0.0
.data 2044 2044 0 0.0
.text 855132 855132 0 0.0
lock-app BRD4161A+wf200 (read/write) 1066376 1066368 -8 -0.0
.bss 153096 153096 0 0.0
.data 2052 2052 0 0.0
.text 911204 911196 -8 -0.0
lighting-app BRD4187C (read/write) 1135704 1135704 0 0.0
.bss 133256 133256 0 0.0
.data 2532 2532 0 0.0
.text 975320 975320 0 0.0
window-app BRD4187C (read/write) 1137320 1137320 0 0.0
.bss 134848 134848 0 0.0
.data 2572 2572 0 0.0
.text 975304 975304 0 0.0
esp32 all-clusters-app c3devkit (read only) 1047830 1047832 2 0.0
(read/write) 1519706 1519706 0 0.0
.dram0.bss 77960 77960 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 221728 221728 0 0.0
.flash.text 1047830 1047832 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1100195 1100195 0 0.0
(read/write) 501347 501343 -4 -0.0
.dram0.bss 83008 83008 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 250488 250484 -4 -0.0
.flash.text 1094811 1094811 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 668876 668876 0 0.0
.bss 77636 77636 0 0.0
.data 2200 2200 0 0.0
.text 569928 569928 0 0.0
light k32w0+release (read/write) 667724 667724 0 0.0
.bss 77332 77332 0 0.0
.data 2188 2188 0 0.0
.text 569092 569092 0 0.0
lock k32w0+release (read/write) 624552 624552 0 0.0
.bss 75468 75468 0 0.0
.data 2132 2132 0 0.0
.text 544224 544224 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12001444 12001444 0 0.0
(read/write) 727720 727720 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670008 670008 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 584148 584148 0 0.0
.text 9690532 9690532 0 0.0
thermostat-no-ble arm64 (read only) 2512356 2512356 0 0.0
(read/write) 145256 145256 0 0.0
.bss 56472 56472 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151136 151136 0 0.0
.text 2099104 2099104 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464848 2464848 0 0.0
.bss 215900 215900 0 0.0
.data 5880 5880 0 0.0
.text 1427492 1427492 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840864 840864 0 0.0
(read/write) 1757916 1757916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189808 189808 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1252899 1252899 0 0.0
.debug_aranges 111416 111416 0 0.0
.debug_frame 374040 374040 0 0.0
.debug_info 27964480 27964479 -1 -0.0
.debug_line 3786906 3786906 0 0.0
.debug_loc 3681184 3681184 0 0.0
.debug_ranges 362576 362576 0 0.0
.debug_str 3513507 3513507 0 0.0
.heap 840864 840864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 578434 578434 0 0.0
.symtab 425104 425104 0 0.0
.text 1557048 1557048 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841680 841680 0 0.0
(read/write) 1699500 1699500 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189000 189000 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238570 1238570 0 0.0
.debug_aranges 110680 110680 0 0.0
.debug_frame 376484 376484 0 0.0
.debug_info 27511958 27511959 1 0.0
.debug_line 3795346 3795346 0 0.0
.debug_loc 3664914 3664914 0 0.0
.debug_ranges 360544 360544 0 0.0
.debug_str 3499260 3499260 0 0.0
.heap 841680 841680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539642 539642 0 0.0
.symtab 410384 410384 0 0.0
.text 1499448 1499448 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849992 849992 0 0.0
(read/write) 1612572 1612572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180888 180888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072904 1072904 0 0.0
.debug_aranges 102888 102888 0 0.0
.debug_frame 346900 346900 0 0.0
.debug_info 22852091 22852092 1 0.0
.debug_line 3347577 3347577 0 0.0
.debug_loc 3342847 3342847 0 0.0
.debug_ranges 319720 319720 0 0.0
.debug_str 3302252 3302252 0 0.0
.heap 849992 849992 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474810 474810 0 0.0
.symtab 378128 378128 0 0.0
.text 1420832 1420832 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845016 845016 0 0.0
(read/write) 1646812 1646812 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185856 185856 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1074608 1074608 0 0.0
.debug_aranges 103328 103328 0 0.0
.debug_frame 348860 348860 0 0.0
.debug_info 23081985 23081984 -1 -0.0
.debug_line 3349365 3349365 0 0.0
.debug_loc 3365804 3365804 0 0.0
.debug_ranges 321632 321632 0 0.0
.debug_str 3319540 3319540 0 0.0
.heap 845016 845016 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478223 478223 0 0.0
.symtab 380320 380320 0 0.0
.text 1450096 1450096 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149188 1149188 0 0.0
.bss 99900 99900 0 0.0
.data 848 848 0 0.0
.text 596288 596288 0 0.0
lock-app qpg6105+debug (read/write) 1116940 1116940 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 564036 564036 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1013676 1013676 0 0.0
bss 97904 97904 0 0.0
text 684646 684644 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950060 950052 -8 -0.0
bss 96956 96956 0 0.0
text 646920 646916 -4 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854920 854920 0 0.0
bss 89076 89076 0 0.0
text 577820 577820 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 870676 870676 0 0.0
bss 89160 89160 0 0.0
text 591862 591862 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948012 948012 0 0.0
bss 97312 97312 0 0.0
text 657266 657264 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882004 882004 0 0.0
bss 90112 90112 0 0.0
text 601608 601608 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874872 874880 8 0.0
bss 90552 90552 0 0.0
text 593444 593448 4 0.0

@woody-apple woody-apple added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 15, 2023
@bzbarsky-apple bzbarsky-apple merged commit 7632b43 into project-chip:master Feb 15, 2023
@bzbarsky-apple bzbarsky-apple deleted the remove-unused-file branch February 15, 2023 15:58
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Remove unused LevelControl.cpp file. (project-chip#25060)
1667866 
The file wouldn't even compile at this point, so it's a good thing it's unused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffamzn cliffamzn cliffamzn approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@msandstedt msandstedt msandstedt approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@kcoppock kcoppock Awaiting requested review from kcoppock

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @msandstedt @jmartinez-silabs @jtung-apple @cliffamzn