-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add missing commands to get TestDiscovery to work. #25056
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_AddMissingCommandsForTestDiscovery
Feb 15, 2023
Merged
[chip-tool] Add missing commands to get TestDiscovery to work. #25056
yufengwangca
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_AddMissingCommandsForTestDiscovery
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
February 14, 2023 16:43
pullapprove
bot
requested review from
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 14, 2023 16:43
vivien-apple
force-pushed
the
ChipTool_AddMissingCommandsForTestDiscovery
branch
from
February 14, 2023 16:44
9f7ead7
to
8e5d148
Compare
bzbarsky-apple
approved these changes
Feb 14, 2023
Fast tracking tests |
vivien-apple
force-pushed
the
ChipTool_AddMissingCommandsForTestDiscovery
branch
from
February 14, 2023 18:41
8e5d148
to
3f40156
Compare
yufengwangca
approved these changes
Feb 14, 2023
PR #25056: Size comparison from a6d2883 to 3f40156 Increases above 0.2%:
Increases (1 build for linux)
Decreases (2 builds for bl702, cc32xx)
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 15, 2023
woody-apple
removed this pull request from the merge queue due to the queue being cleared
Feb 15, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ests
Problem
TestDiscovery
does not work withchip-tool
adapter on top ofmatter_yamltests
. This PR adds the missing commands.