Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TC-SC-5.2] Update the test to really check if the group message has been received #25051

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[TC-SC-5.2] Update the test to really check if the group message has been received #25051

merged 2 commits into from
Feb 16, 2023

Conversation

vivien-apple
Copy link
Contributor

Problem

Test_TC_SC_5_2.yaml expects a group response when it should not. This PR is an attempt at getting it to really check that the group message has been received properly.

It is a draft until https://github.com/CHIP-Specifications/chip-test-plans/issues/2431 confirms that it is fine.

@vivien-apple vivien-apple self-assigned this Feb 14, 2023
@vivien-apple vivien-apple changed the title [TC-SC-5.2] Update the test to really check if the group message has … … …been received [TC-SC-5.2] Update the test to really check if the group message has been received Feb 14, 2023
@github-actions
Copy link

PR #25051: Size comparison from 6ce0f90 to 999c01a

Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 6ce0f90 999c01a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180781 20180781 0 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464688 2464688 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427332 1427332 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149152 1149152 0 0.0
.bss 99900 99900 0 0.0
.data 848 848 0 0.0
.text 596252 596252 0 0.0
lock-app qpg6105+debug (read/write) 1116896 1116896 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563992 563992 0 0.0

@vivien-apple vivien-apple force-pushed the TC_SC_5_2_UpdateToNotExpectAGroupResponse branch from 999c01a to 04b07c8 Compare February 14, 2023 21:20
@vivien-apple vivien-apple marked this pull request as ready for review February 14, 2023 21:23
@github-actions
Copy link

PR #25051: Size comparison from a6d2883 to 04b07c8

Full report (4 builds for cc32xx, mbed, qpg)
platform target config section a6d2883 04b07c8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640577 640577 0 0.0
(read/write) 204100 204100 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197504 197504 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 930806 930806 0 0.0
.debug_aranges 87360 87360 0 0.0
.debug_frame 299864 299864 0 0.0
.debug_info 20307078 20307078 0 0.0
.debug_line 2654650 2654650 0 0.0
.debug_loc 2787110 2787110 0 0.0
.debug_ranges 280904 280904 0 0.0
.debug_str 3001983 3001983 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105665 105665 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375952 375952 0 0.0
.symtab 255888 255888 0 0.0
.text 532792 532792 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464912 2464912 0 0.0
.bss 215908 215908 0 0.0
.data 5880 5880 0 0.0
.text 1427556 1427556 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149220 1149220 0 0.0
.bss 99908 99908 0 0.0
.data 848 848 0 0.0
.text 596320 596320 0 0.0
lock-app qpg6105+debug (read/write) 1116964 1116964 0 0.0
.bss 96404 96404 0 0.0
.data 860 860 0 0.0
.text 564060 564060 0 0.0

@vivien-apple vivien-apple force-pushed the TC_SC_5_2_UpdateToNotExpectAGroupResponse branch from 04b07c8 to ead0b1d Compare February 16, 2023 09:48
@github-actions
Copy link

PR #25051: Size comparison from 352efee to ead0b1d

Decreases (1 build for cc32xx)
platform target config section 352efee ead0b1d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20338087 20338086 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 352efee ead0b1d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338087 20338086 -1 -0.0
.debug_line 2657824 2657824 0 0.0
.debug_loc 2790649 2790649 0 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3003658 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@yufengwangca yufengwangca merged commit b8eee57 into project-chip:master Feb 16, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[TC-SC-5.2] Update the test to really check if the group message has …
326cbea 
…been received (project-chip#25051)

* [TC-SC-5.2] Update the test to really check if the group message has been received

* Update generated tests code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tehampson tehampson tehampson approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

@vivien-apple vivien-apple

Labels
app darwin examples review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @tehampson @bzbarsky-apple @yufengwangca