Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Supported Events to the Thermostat App ZAP File #25036

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Added Supported Events to the Thermostat App ZAP File #25036

merged 2 commits into from
Feb 15, 2023

Conversation

emargolis
Copy link
Contributor

No description provided.

@github-actions
Copy link

PR #25036: Size comparison from e7528bc to 87675ff

Increases (1 build for cc32xx)
platform target config section e7528bc 87675ff change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180782 2018078 1 0.0
Full report (1 build for cc32xx)
platform target config section e7528bc 87675ff change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180782 2018078 1 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) February 14, 2023 16:55
@emargolis emargolis force-pushed the emargolis/feature/fix-examples-thermostat-zap-events branch from 87675ff to 54b4acf Compare February 14, 2023 18:13
@pullapprove pullapprove bot requested a review from kkasperczyk-no February 14, 2023 18:13
@github-actions
Copy link

PR #25036: Size comparison from bd78b86 to 54b4acf

Increases (1 build for cc32xx)
platform target config section bd78b86 54b4acf change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20250998 20250999 1 0.0
Full report (3 builds for cc32xx, qpg)
platform target config section bd78b86 54b4acf change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640545 640545 0 0.0
(read/write) 204092 204092 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197496 197496 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 929366 929366 0 0.0
.debug_aranges 87360 87360 0 0.0
.debug_frame 299868 299868 0 0.0
.debug_info 20250998 20250999 1 0.0
.debug_line 2652227 2652227 0 0.0
.debug_loc 2786303 2786303 0 0.0
.debug_ranges 280856 280856 0 0.0
.debug_str 3005403 3005403 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105665 105665 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375952 375952 0 0.0
.symtab 255888 255888 0 0.0
.text 532760 532760 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149188 1149188 0 0.0
.bss 99900 99900 0 0.0
.data 848 848 0 0.0
.text 596288 596288 0 0.0
lock-app qpg6105+debug (read/write) 1116940 1116940 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 564036 564036 0 0.0

@woody-apple woody-apple disabled auto-merge February 14, 2023 20:51
@woody-apple woody-apple added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2023
@emargolis emargolis added this pull request to the merge queue Feb 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 15, 2023
@yufengwangca yufengwangca merged commit 552e6eb into project-chip:master Feb 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@emargolis
Added Supported Events to the Thermostat App ZAP File (project-chip#2…
d1058cc 
…5036)

* Added Supported Events to the Thermostat App ZAP File

* ZAP REGEN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @andy31415 @bzbarsky-apple @yufengwangca