Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to generate events when we clear credentials. #25028

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Make sure to generate events when we clear credentials. #25028

merged 2 commits into from
Feb 14, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

We could end up in a situation where we cleared some credentials, then hit an error, and never generated the event for the credentials we had cleared.

@bzbarsky-apple
Make sure to generate events when we clear credentials.
796f10a 
We could end up in a situation where we cleared some credentials, then
hit an error, and never generated the event for the credentials we had
cleared.
@github-actions github-actions bot added the app label Feb 13, 2023
@pullapprove pullapprove bot requested a review from yunhanw-google February 13, 2023 22:06
@github-actions
Copy link

PR #25028: Size comparison from 9508b52 to 796f10a

Increases (1 build for cc32xx)
platform target config section 9508b52 796f10a change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 640361 640377 16 0.0
.debug_frame 299840 299844 4 0.0
.debug_info 20180782 20180811 29 0.0
.debug_line 2649926 2649959 33 0.0
.debug_loc 2786017 2786117 100 0.0
.debug_str 3005287 3005305 18 0.0
.text 532604 532620 16 0.0
Decreases (1 build for cc32xx)
platform target config section 9508b52 796f10a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_ranges 280728 280720 -8 -0.0
Full report (1 build for cc32xx)
platform target config section 9508b52 796f10a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640377 16 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299844 4 0.0
.debug_info 20180782 20180811 29 0.0
.debug_line 2649926 2649959 33 0.0
.debug_loc 2786017 2786117 100 0.0
.debug_ranges 280728 280720 -8 -0.0
.debug_str 3005287 3005305 18 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532620 16 0.0

@github-actions
Copy link

PR #25028: Size comparison from 9508b52 to 1d2c48a

Increases (4 builds for bl702, cc32xx, nrfconnect)
platform target config section 9508b52 1d2c48a change % change
bl702 lighting-app bl702+rpc .debug_info 44966857 44966858 1 0.0
.text 1030266 1030268 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 640361 640409 48 0.0
.debug_frame 299840 299844 4 0.0
.debug_info 20180782 20180827 45 0.0
.debug_loc 2786017 2786137 120 0.0
.debug_str 3005287 3005305 18 0.0
.text 532604 532652 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1162472 1162488 16 0.0
text 804616 804636 20 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1367708 1367724 16 0.0
text 764320 764344 24 0.0
Decreases (2 builds for bl602, cc32xx)
platform target config section 9508b52 1d2c48a change % change
bl602 lighting-app bl602 .text 1023380 1023378 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2649926 2649924 -2 -0.0
Full report (11 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect)
platform target config section 9508b52 1d2c48a change % change
bl602 lighting-app bl602 (read/write) 1346734 1346734 0 0.0
.bss 94802 94802 0 0.0
.data 9736 9736 0 0.0
.text 1023380 1023378 -2 -0.0
bl602+rpc (read/write) 1392166 1392166 0 0.0
.bss 102850 102850 0 0.0
.data 10128 10128 0 0.0
.text 1054314 1054314 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185179 1185179 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69905 69905 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550508 1550508 0 0.0
.debug_aranges 134264 134264 0 0.0
.debug_frame 491736 491736 0 0.0
.debug_info 40558718 40558718 0 0.0
.debug_line 5273540 5273540 0 0.0
.debug_loc 3409115 3409115 0 0.0
.debug_ranges 371688 371688 0 0.0
.debug_str 3563128 3563128 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107200 107200 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572957 572957 0 0.0
.symtab 173536 173536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 952872 952872 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1278335 1278335 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77953 77953 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698984 1698984 0 0.0
.debug_aranges 142496 142496 0 0.0
.debug_frame 519484 519484 0 0.0
.debug_info 44966857 44966858 1 0.0
.debug_line 5672591 5672591 0 0.0
.debug_loc 3606033 3606033 0 0.0
.debug_ranges 395456 395456 0 0.0
.debug_str 3966620 3966620 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121840 121840 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634016 634016 0 0.0
.symtab 192000 192000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030266 1030268 2 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640409 48 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299844 4 0.0
.debug_info 20180782 20180827 45 0.0
.debug_line 2649926 2649924 -2 -0.0
.debug_loc 2786017 2786137 120 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005305 18 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532652 48 0.0
linux chip-tool-ipv6only arm64 (read only) 11995524 11995524 0 0.0
(read/write) 727720 727720 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670008 670008 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 583332 583332 0 0.0
.text 9685428 9685428 0 0.0
thermostat-no-ble arm64 (read only) 2511700 2511700 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151088 151088 0 0.0
.text 2098496 2098496 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464688 2464688 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427332 1427332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162472 1162488 16 0.0
bss 143531 143531 0 0.0
rodata 134436 134436 0 0.0
text 804616 804636 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108488 1108488 0 0.0
bss 142687 142687 0 0.0
rodata 111428 111428 0 0.0
text 774608 774608 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367708 1367724 16 0.0
bss 105990 105990 0 0.0
rodata 211868 211868 0 0.0
text 764320 764344 24 0.0

@bzbarsky-apple bzbarsky-apple merged commit bd86634 into project-chip:master Feb 14, 2023
@bzbarsky-apple bzbarsky-apple deleted the lock-clear-credential-event branch February 14, 2023 17:02
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Make sure to generate events when we clear credentials. (project-chip…
91bed97 
…#25028)

* Make sure to generate events when we clear credentials.

We could end up in a situation where we cleared some credentials, then
hit an error, and never generated the event for the credentials we had
cleared.

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhees-cae jrhees-cae jrhees-cae left review comments

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @woody-apple @jrhees-cae