-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not install matter yamltests in env (this has sideffects and cause… #25022
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:stop_installint_idl_parser_in_env
Feb 15, 2023
Merged
Do not install matter yamltests in env (this has sideffects and cause… #25022
andy31415
merged 2 commits into
project-chip:master
from
andy31415:stop_installint_idl_parser_in_env
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s codegen.py confusion)
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google and
mrjerryjohns
February 13, 2023 19:14
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
February 13, 2023 19:14
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 13, 2023 19:14
PR #25022: Size comparison from b3c599d to e81b8f4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
@andy31415 Does #25024 address the same thing? |
Yes, I will use this to test out path replacement, however #25024 seems more complete and should be the change we take. I thought just removing the install was sufficient, but apparently we need to fix our script path taking as well. |
… exist in the current environment
bzbarsky-apple
approved these changes
Feb 14, 2023
tehampson
approved these changes
Feb 15, 2023
auto-merge was automatically disabled
February 15, 2023 13:42
Merge queue setting changed
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
project-chip#25022) * Do not install matter yamltests in env (this has sideffects and causes codegen.py confusion) * Attempt to make yamltester be able to sort its imports if they do not exist in the current environment --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s codegen.py confusion)
Errors like:
are not obviously "old matter idl in build env".
In GN we could add a dependency on codegen.py to require install of deps in the env first, however I am unsure if this problem is easily solvable in cmake ... so I would rather not pollute the env in the first place.
I am also skeptic on the rpc_console install ... but for now keeping that.