Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install matter yamltests in env (this has sideffects and cause… #25022

Merged

Conversation

andy31415
Copy link
Contributor

…s codegen.py confusion)

Errors like:

2023-02-13 13:20:35 INFO    Parsing idl from ../../../examples/all-clusters-app/linux/third_party/connectedhomeip/examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
2023-02-13 13:20:36 INFO    Running code generator cpp-app
Traceback (most recent call last):
  File "/Users/bzbarsky/connectedhomeip/out/debug/standalone/../../../examples/all-clusters-app/linux/third_party/connectedhomeip/scripts/codegen.py", line 165, in <module>
    main(auto_envvar_prefix='CHIP')
  File "/Users/bzbarsky/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/bzbarsky/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/bzbarsky/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/bzbarsky/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/bzbarsky/connectedhomeip/out/debug/standalone/../../../examples/all-clusters-app/linux/third_party/connectedhomeip/scripts/codegen.py", line 136, in main
    generator = CodeGenerator.FromString(generator).Create(storage, idl=idl_tree, plugin_module=plugin_module)
  File "/Users/bzbarsky/connectedhomeip/.environment/pigweed-venv/lib/python3.9/site-packages/matter_idl/generators/registry.py", line 38, in Create
    return CppApplicationGenerator(*args, **kargs)
TypeError: __init__() got an unexpected keyword argument 'plugin_module'
[18/713] ACTION //third_party/connectedhomeip/examples/all-clusters-app/all-...zap_pregen(//third_party/connectedhomeip/build/toolchain/host:mac_arm64_gcc)
ninja: build stopped: subcommand failed.

are not obviously "old matter idl in build env".
In GN we could add a dependency on codegen.py to require install of deps in the env first, however I am unsure if this problem is easily solvable in cmake ... so I would rather not pollute the env in the first place.

I am also skeptic on the rpc_console install ... but for now keeping that.

@github-actions
Copy link

PR #25022: Size comparison from b3c599d to e81b8f4

Increases (1 build for cc32xx)
platform target config section b3c599d e81b8f4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20180781 20180782 1 0.0
Full report (1 build for cc32xx)
platform target config section b3c599d e81b8f4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180781 20180782 1 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@bzbarsky-apple
Copy link
Contributor

@andy31415 Does #25024 address the same thing?

@andy31415
Copy link
Contributor Author

@andy31415 Does #25024 address the same thing?

Yes, I will use this to test out path replacement, however #25024 seems more complete and should be the change we take. I thought just removing the install was sufficient, but apparently we need to fix our script path taking as well.

auto-merge was automatically disabled February 15, 2023 13:42

Merge queue setting changed

@andy31415 andy31415 merged commit 4b4d3de into project-chip:master Feb 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
project-chip#25022)

* Do not install matter yamltests in env (this has sideffects and causes codegen.py confusion)

* Attempt to make yamltester be able to sort its imports if they do not exist in the current environment

---------

Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants