Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matter_yamltests] Stop failing is no definitions is used for matter_… #25021

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[matter_yamltests] Stop failing is no definitions is used for matter_… #25021

merged 1 commit into from
Feb 13, 2023

Conversation

vivien-apple
Copy link
Contributor

…yamltests

Problem

Sometimes when writing tests you don't necessarily needs to use a definition.

It just miss a check of definitions is not None to get that working.

@vivien-apple vivien-apple self-assigned this Feb 13, 2023
@github-actions
Copy link

github-actions bot commented Feb 13, 2023 •
edited
Loading

PR #25021: Size comparison from b04c8ca to 280b13d

Increases (6 builds for bl602, bl702, cc32xx, psoc6, telink)
platform target config section b04c8ca 280b13d change % change
bl602 lighting-app bl602+rpc .text 1054310 1054312 2 0.0
bl702 lighting-app bl702+rpc .debug_info 4497573 44975735 1 0.0
.text 1030264 1030266 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20188403 20188404 1 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27904089 27904090 1 0.0
telink all-clusters-app tlsr9518adk80d text 684612 684614 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 646910 646912 2 0.0
Decreases (6 builds for efr32, esp32, nrfconnect, telink)
platform target config section b04c8ca 280b13d change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1066192 1066184 -8 -0.0
.text 911028 911020 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1047672 1047670 -2 -0.0
.flash.text 1047672 1047670 -2 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1367708 1367692 -16 -0.0
text 764320 764316 -4 -0.0
telink lighting-app tlsr9518adk80d text 657248 657246 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 881964 881956 -8 -0.0
text 601594 601592 -2 -0.0
thermostat tlsr9518adk80d text 593428 593426 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b04c8ca 280b13d change % change
bl602 lighting-app bl602 (read/write) 1346726 1346726 0 0.0
.bss 94802 94802 0 0.0
.data 9736 9736 0 0.0
.text 1023376 1023376 0 0.0
bl602+rpc (read/write) 1392158 1392158 0 0.0
.bss 102850 102850 0 0.0
.data 10128 10128 0 0.0
.text 1054310 1054312 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1185179 1185179 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69905 69905 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550508 1550508 0 0.0
.debug_aranges 134264 134264 0 0.0
.debug_frame 491736 491736 0 0.0
.debug_info 40567503 40567503 0 0.0
.debug_line 5273540 5273540 0 0.0
.debug_loc 3409103 3409103 0 0.0
.debug_ranges 371688 371688 0 0.0
.debug_str 3560697 3560697 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107200 107200 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572895 572895 0 0.0
.symtab 173536 173536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952868 952868 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1278335 1278335 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77953 77953 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698984 1698984 0 0.0
.debug_aranges 142496 142496 0 0.0
.debug_frame 519484 519484 0 0.0
.debug_info 4497573 44975735 1 0.0
.debug_line 5672591 5672591 0 0.0
.debug_loc 3606019 3606019 0 0.0
.debug_ranges 395456 395456 0 0.0
.debug_str 3964189 3964189 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121840 121840 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 633954 633954 0 0.0
.symtab 192000 192000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1030264 1030266 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678315 678315 0 0.0
(read/write) 172868 172868 0 0.0
.bss 80876 80876 0 0.0
.data 3384 3384 0 0.0
.rodata 88371 88371 0 0.0
.text 589628 589628 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642139 642139 0 0.0
(read/write) 157568 157568 0 0.0
.bss 80068 80068 0 0.0
.data 3384 3384 0 0.0
.rodata 78163 78163 0 0.0
.text 563656 563656 0 0.0
lock-ftd LP_CC2652R7 (read only) 675207 675207 0 0.0
(read/write) 173328 173328 0 0.0
.bss 78316 78316 0 0.0
.data 3312 3312 0 0.0
.rodata 76671 76671 0 0.0
.text 598056 598056 0 0.0
lock-mtd LP_CC2652R7 (read only) 661631 661631 0 0.0
(read/write) 182160 182160 0 0.0
.bss 73572 73572 0 0.0
.data 3312 3312 0 0.0
.rodata 103263 103263 0 0.0
.text 557888 557888 0 0.0
pump-app LP_CC2652R7 (read only) 688275 688275 0 0.0
(read/write) 160996 160996 0 0.0
.bss 78284 78284 0 0.0
.data 3276 3276 0 0.0
.rodata 90795 90795 0 0.0
.text 597000 597000 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673643 673643 0 0.0
(read/write) 175740 175740 0 0.0
.bss 78396 78396 0 0.0
.data 3300 3300 0 0.0
.rodata 86835 86835 0 0.0
.text 586328 586328 0 0.0
shell LP_CC2652R7 (read only) 669594 669594 0 0.0
(read/write) 183660 183660 0 0.0
.bss 82948 82948 0 0.0
.data 3380 3380 0 0.0
.rodata 85122 85122 0 0.0
.text 584160 584160 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 640361 640361 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20188403 20188404 1 0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786018 2786018 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3002856 3002856 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105633 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 0 0 0 0.0
532604 532604 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584974 584974 0 0.0
.app_xip_area 461768 461768 0 0.0
.bss 65648 65648 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588938 588938 0 0.0
.app_xip_area 460436 460436 0 0.0
.bss 70936 70936 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550126 550126 0 0.0
.app_xip_area 432424 432424 0 0.0
.bss 60192 60192 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1038488 1038488 0 0.0
.bss 181568 181568 0 0.0
.data 2044 2044 0 0.0
.text 854856 854856 0 0.0
BRD4187C (read/write) 1135552 1135552 0 0.0
.bss 133256 133256 0 0.0
.data 2532 2532 0 0.0
.text 975168 975168 0 0.0
lock-app BRD4161A+wf200 (read/write) 1066192 1066184 -8 -0.0
.bss 153088 153088 0 0.0
.data 2052 2052 0 0.0
.text 911028 911020 -8 -0.0
window-app BRD4187C (read/write) 1137168 1137168 0 0.0
.bss 134848 134848 0 0.0
.data 2572 2572 0 0.0
.text 975152 975152 0 0.0
esp32 all-clusters-app c3devkit (read only) 1047672 1047670 -2 -0.0
(read/write) 1519618 1519618 0 0.0
.dram0.bss 77960 77960 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 221640 221640 0 0.0
.flash.text 1047672 1047670 -2 -0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1100067 1100067 0 0.0
(read/write) 501259 501259 0 0.0
.dram0.bss 83008 83008 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 250400 250400 0 0.0
.flash.text 1094683 1094683 0 0.0
.iram0.text 124855 124855 0 0.0
linux chip-tool-ipv6only arm64 (read only) 1199779 1199779 0 0.0
(read/write) 727720 727720 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670008 670008 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 583268 583268 0 0.0
.text 9687764 9687764 0 0.0
thermostat-no-ble arm64 (read only) 2511700 2511700 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151088 151088 0 0.0
.text 2098496 2098496 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464688 2464688 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427332 1427332 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162472 1162472 0 0.0
bss 143531 143531 0 0.0
rodata 134436 134436 0 0.0
text 804616 804616 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367708 1367692 -16 -0.0
bss 105990 105990 0 0.0
rodata 211868 211868 0 0.0
text 764320 764316 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108488 1108488 0 0.0
bss 142687 142687 0 0.0
rodata 111428 111428 0 0.0
text 774608 774608 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840872 840872 0 0.0
(read/write) 1757628 1757628 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189800 189800 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251990 1251990 0 0.0
.debug_aranges 111408 111408 0 0.0
.debug_frame 373996 373996 0 0.0
.debug_info 27904089 27904090 1 0.0
.debug_line 3784202 3784202 0 0.0
.debug_loc 3680917 3680917 0 0.0
.debug_ranges 362448 362448 0 0.0
.debug_str 3510960 3510960 0 0.0
.heap 840872 840872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 578322 578322 0 0.0
.symtab 425056 425056 0 0.0
.text 1556768 1556768 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841688 841688 0 0.0
(read/write) 1699236 1699236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188992 188992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237661 1237661 0 0.0
.debug_aranges 110672 110672 0 0.0
.debug_frame 376440 376440 0 0.0
.debug_info 27451302 27451302 0 0.0
.debug_line 3792546 3792546 0 0.0
.debug_loc 3664648 3664648 0 0.0
.debug_ranges 360416 360416 0 0.0
.debug_str 3496713 3496713 0 0.0
.heap 841688 841688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539530 539530 0 0.0
.symtab 410336 410336 0 0.0
.text 1499192 1499192 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850000 850000 0 0.0
(read/write) 1612308 1612308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180880 180880 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071995 1071995 0 0.0
.debug_aranges 102880 102880 0 0.0
.debug_frame 346876 346876 0 0.0
.debug_info 22788645 22788645 0 0.0
.debug_line 3344859 3344859 0 0.0
.debug_loc 3342647 3342647 0 0.0
.debug_ranges 319592 319592 0 0.0
.debug_str 3299723 3299723 0 0.0
.heap 850000 850000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474698 474698 0 0.0
.symtab 378080 378080 0 0.0
.text 1420576 1420576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845024 845024 0 0.0
(read/write) 1646548 1646548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185848 185848 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073699 1073699 0 0.0
.debug_aranges 103320 103320 0 0.0
.debug_frame 348816 348816 0 0.0
.debug_info 23018574 23018574 0 0.0
.debug_line 3346757 3346757 0 0.0
.debug_loc 3365541 3365541 0 0.0
.debug_ranges 321504 321504 0 0.0
.debug_str 3316993 3316993 0 0.0
.heap 845024 845024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478111 478111 0 0.0
.symtab 380272 380272 0 0.0
.text 1449840 1449840 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149152 1149152 0 0.0
.bss 99900 99900 0 0.0
.data 848 848 0 0.0
.text 596252 596252 0 0.0
lock-app qpg6105+debug (read/write) 1116896 1116896 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563992 563992 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1013612 1013612 0 0.0
bss 97904 97904 0 0.0
text 684612 684614 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950020 950020 0 0.0
bss 96956 96956 0 0.0
text 646910 646912 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854876 854876 0 0.0
bss 89076 89076 0 0.0
text 577800 577800 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 870620 870620 0 0.0
bss 89160 89160 0 0.0
text 591844 591844 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 947964 947964 0 0.0
bss 97312 97312 0 0.0
text 657248 657246 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881964 881956 -8 -0.0
bss 90112 90112 0 0.0
text 601594 601592 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874824 874824 0 0.0
bss 90552 90552 0 0.0
text 593428 593426 -2 -0.0

@vivien-apple vivien-apple enabled auto-merge (squash) February 13, 2023 19:25
@vivien-apple vivien-apple merged commit 9508b52 into project-chip:master Feb 13, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[matter_yamltests] Stop failing is no definitions is used for matter_…
44a1ac5 
…yamltests (project-chip#25021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivien-apple @andy31415