-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Fixed compilation with Bluedroid related errors for all-clusters-app. #25006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25006: Size comparison from bbfd5d6 to 55cc267 Full report (1 build for cc32xx)
|
shripad621git
force-pushed
the
Bludroid_fix
branch
from
February 13, 2023 08:43
55cc267
to
3bf3bb5
Compare
shripad621git
force-pushed
the
Bludroid_fix
branch
from
February 13, 2023 08:54
3bf3bb5
to
0636879
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
jtung-apple
February 13, 2023 08:55
pullapprove
bot
requested review from
kcoppock,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 13, 2023 08:55
PR #25006: Size comparison from bbfd5d6 to 0636879 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
shripad621git
changed the title
Fixed compilation with Bluedroid related errors for all-clusters-app.
[ESP32] Fixed compilation with Bluedroid related errors for all-clusters-app.
Feb 13, 2023
harsha-rajendran
approved these changes
Feb 13, 2023
andy31415
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the compilation errors in compilation of all-clusters-app with Bluedroid.
Problem:
The compilation of all-clusters-app was failing when compiled with Bluedroid as the option set in the menuconfig for Bluetooth host on ESP32 platform.
Change Overview:
Included the log library <esp_log.h> to fix the log related errors encountered in examples/all-clusters-app/esp32/main/DeviceCallbacks.cpp and examples/platform/esp32/lock/BoltLockManager.cpp.
Testing
Successfully compiled the all-clusters-app for esp32c3 with Bluedroid as the option set in the menuconfig for Bluetooth host.