-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache bootstrap step in all CI workflows #24968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
config
documentation
Improvements or additions to documentation
github
gn
scripts
workflows
labels
Feb 10, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
ksperling-apple
February 10, 2023 12:30
pullapprove
bot
requested review from
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 10, 2023 12:30
PR #24968: Size comparison from 1f81384 to b102b1a Increases (2 builds for bl602, bl702)
Decreases (1 build for qpg)
Full report (7 builds for bl602, bl702, cc32xx, qpg)
|
andy31415
reviewed
Feb 10, 2023
Keeping all files used to bootstrap the project in a dedicated directory will simplify environment cache invalidation.
andy31415
approved these changes
Feb 13, 2023
bzbarsky-apple
approved these changes
Feb 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Move bootstrap configuration files to separate dir Keeping all files used to bootstrap the project in a dedicated directory will simplify environment cache invalidation. * Compatibility for old location of bootstrap script * Cache bootstrap step in all CI workflows * Update constraints location in config files * Hash all pigweed files when creating cache key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
documentation
Improvements or additions to documentation
github
gn
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bootstrap takes ~5-6min to complete and is used in almost all workflows. Caching this step can save ~4-5min (restore takes ~1min).
Changes
Testing
CI will test that in a 2 steps process: