Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix level control print out for strings #24949

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix level control print out for strings #24949

merged 2 commits into from
Feb 13, 2023

Conversation

mkardous-silabs
Copy link
Contributor

Description

Level control print out was using %p which was printing out an address instead of the actual string.

Tests

Manuel tests validating the print out

@github-actions github-actions bot added the app label Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

PR #24949: Size comparison from 9c631df to 854c78c

Increases (3 builds for bl602, qpg)
platform target config section 9c631df 854c78c change % change
bl602 lighting-app bl602 (read/write) 1346582 1346590 8 0.0
bl602+rpc (read/write) 1392014 1392022 8 0.0
qpg lighting-app qpg6105+debug (read/write) 1148688 1148704 16 0.0
.text 595788 595804 16 0.0
Decreases (4 builds for bl602, bl702, cc32xx)
platform target config section 9c631df 854c78c change % change
bl602 lighting-app bl602 .text 1023324 1023322 -2 -0.0
bl702 lighting-app bl702 .debug_info 40536301 4053630 -1 -0.0
.text 952438 952436 -2 -0.0
bl702+rpc .debug_info 44938490 44938489 -1 -0.0
.text 1029630 1029628 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 640233 640225 -8 -0.0
.debug_info 20194396 20194394 -2 -0.0
.text 532524 532516 -8 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section 9c631df 854c78c change % change
bl602 lighting-app bl602 (read/write) 1346582 1346590 8 0.0
.bss 94794 94794 0 0.0
.data 9736 9736 0 0.0
.text 1023324 1023322 -2 -0.0
bl602+rpc (read/write) 1392014 1392022 8 0.0
.bss 102842 102842 0 0.0
.data 10128 10128 0 0.0
.text 1054256 1054256 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1184651 1184651 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69905 69905 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550382 1550382 0 0.0
.debug_aranges 134192 134192 0 0.0
.debug_frame 491492 491492 0 0.0
.debug_info 40536301 4053630 -1 -0.0
.debug_line 5272965 5272965 0 0.0
.debug_loc 3409446 3409446 0 0.0
.debug_ranges 371752 371752 0 0.0
.debug_str 3558337 3558337 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107120 107120 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572518 572518 0 0.0
.symtab 173424 173424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 952438 952436 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1277535 1277535 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77953 77953 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698796 1698796 0 0.0
.debug_aranges 142424 142424 0 0.0
.debug_frame 519236 519236 0 0.0
.debug_info 44938490 44938489 -1 -0.0
.debug_line 5671672 5671672 0 0.0
.debug_loc 3606205 3606205 0 0.0
.debug_ranges 395520 395520 0 0.0
.debug_str 3961701 3961701 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121696 121696 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 633311 633311 0 0.0
.symtab 191840 191840 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1029630 1029628 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640225 -8 -0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194396 20194394 -2 -0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532516 -8 -0.0
linux chip-tool-ipv6only arm64 (read only) 11997396 11997396 0 0.0
(read/write) 727720 727720 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670008 670008 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 583220 583220 0 0.0
.text 9687412 9687412 0 0.0
thermostat-no-ble arm64 (read only) 2510292 2510292 0 0.0
(read/write) 145224 145224 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151040 151040 0 0.0
.text 2097280 2097280 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148688 1148704 16 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595788 595804 16 0.0
lock-app qpg6105+debug (read/write) 1116736 1116736 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563832 563832 0 0.0

@github-actions
Copy link

PR #24949: Size comparison from 5ad70f6 to b7ab845

Increases (1 build for cc32xx)
platform target config section 5ad70f6 b7ab845 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194394 20194395 1 0.0
Full report (1 build for cc32xx)
platform target config section 5ad70f6 b7ab845 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194394 20194395 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@jmartinez-silabs jmartinez-silabs enabled auto-merge (squash) February 10, 2023 20:42
@jmartinez-silabs jmartinez-silabs merged commit af1b471 into project-chip:master Feb 13, 2023
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 24, 2023
Closed
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@mkardous-silabs
Fix level control print out for strings (project-chip#24949)
211a360 
* fix level control logs

* restyle
@mkardous-silabs mkardous-silabs deleted the fix/lvl_ctrl_logs branch August 4, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@rcasallas-silabs rcasallas-silabs rcasallas-silabs approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkardous-silabs @jmartinez-silabs @rcasallas-silabs @jtung-apple