-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[administrator-commissioning-cluster] Remove StatusCode from weak-enum-list.yaml #24940
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:RemoveWeakEnum_StatusCode
Feb 13, 2023
Merged
[administrator-commissioning-cluster] Remove StatusCode from weak-enum-list.yaml #24940
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:RemoveWeakEnum_StatusCode
Feb 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 9, 2023 08:47
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
February 9, 2023 08:47
PR #24940: Size comparison from cc0f0d8 to 2da9cda Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Feb 9, 2023
vivien-apple
force-pushed
the
RemoveWeakEnum_StatusCode
branch
from
February 10, 2023 16:41
2da9cda
to
c0ff3e3
Compare
PR #24940: Size comparison from f0262a0 to c0ff3e3 Increases (21 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, linux, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
vivien-apple
changed the title
[administator-commissioning-cluster] Remove StatusCode from weak-enum-list.yaml
[administrator-commissioning-cluster] Remove StatusCode from weak-enum-list.yaml
Feb 13, 2023
andy31415
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
StatusCode
is a weak enum exception. This PR removes it fromweak-enum-list.yaml
and update the code accordingly.