Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified tests Feb 07 #24898

Merged
merged 6 commits into from
Feb 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/app/tests/suites/certification/Test_TC_ACL_2_10.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ config:
nodeId2:
type: node_id
defaultValue: 0xCAFE
TH1CommissionerNodeId:
type: node_id
defaultValue: 112233
TH2CommissionerNodeId:
type: node_id
defaultValue: 112233
discriminator:
type: int16u
defaultValue: 3840
Expand All @@ -53,6 +47,14 @@ tests:
- name: "nodeId"
value: nodeId

- label: "Read the TH1 commissioner node ID"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: TH1CommissionerNodeId

- label:
"Step 2:TH1 reads OperationalCredentials cluster CurrentFabricIndex
attribute"
Expand Down Expand Up @@ -93,6 +95,15 @@ tests:
- name: "nodeId"
value: nodeId2

- label: "Read the TH2 commissioner node ID"
identity: "beta"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: TH2CommissionerNodeId

- label:
"Step 4:TH2 reads OperationalCredentials cluster CurrentFabricIndex
attribute"
Expand Down
11 changes: 8 additions & 3 deletions src/app/tests/suites/certification/Test_TC_ACL_2_4.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ config:
nodeId: 0x12344321
cluster: "Access Control"
endpoint: 0
CommissionerNodeId:
type: node_id
defaultValue: 112233
CAT1:
type: int64u
defaultValue: 65520
Expand All @@ -47,6 +44,14 @@ tests:
- name: "nodeId"
value: nodeId

- label: "Read the commissioner node ID"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: CommissionerNodeId

- label:
"Step 2:TH1 reads DUT Endpoint 0 OperationalCredentials cluster
CurrentFabricIndex attribute"
Expand Down
23 changes: 17 additions & 6 deletions src/app/tests/suites/certification/Test_TC_ACL_2_7.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ config:
nodeId2:
type: node_id
defaultValue: 0xCAFE
TH1CommissionerNodeId:
type: node_id
defaultValue: 112233
TH2CommissionerNodeId:
type: node_id
defaultValue: 112233
payload:
type: char_string
defaultValue: "MT:-24J0AFN00KA0648G00"
Expand All @@ -50,6 +44,14 @@ tests:
- name: "nodeId"
value: nodeId

- label: "Read the TH1 commissioner node ID"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: TH1CommissionerNodeId

- label:
"Step 2:TH1 reads OperationalCredentials cluster CurrentFabricIndex
attribute"
Expand Down Expand Up @@ -90,6 +92,15 @@ tests:
- name: "nodeId"
value: nodeId2

- label: "Read the TH2 commissioner node ID"
identity: "beta"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: TH2CommissionerNodeId

- label:
"Step 5:TH2 reads OperationalCredentials cluster CurrentFabricIndex
attribute"
Expand Down
23 changes: 17 additions & 6 deletions src/app/tests/suites/certification/Test_TC_ACL_2_8.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ config:
nodeId2:
type: node_id
defaultValue: 0xCAFE
TH1CommissionerNodeId:
type: node_id
defaultValue: 112233
TH2CommissionerNodeId:
type: node_id
defaultValue: 112233
payload:
type: char_string
defaultValue: "MT:-24J0AFN00KA0648G00"
Expand All @@ -43,6 +37,14 @@ tests:
- name: "nodeId"
value: nodeId

- label: "Read the TH1 commissioner node ID"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: TH1CommissionerNodeId

- label:
"TH1 reads OperationalCredentials cluster CurrentFabricIndex attribute"
command: "readAttribute"
Expand Down Expand Up @@ -82,6 +84,15 @@ tests:
- name: "nodeId"
value: nodeId2

- label: "Read the TH2 commissioner node ID"
identity: "beta"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: TH2CommissionerNodeId

- label:
"TH2 reads OperationalCredentials cluster CurrentFabricIndex attribute"
identity: "beta"
Expand Down
17 changes: 11 additions & 6 deletions src/app/tests/suites/certification/Test_TC_ACL_2_9.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ config:
nodeId2:
type: node_id
defaultValue: 0xCAFE
CommissionerNodeId:
type: node_id
defaultValue: 112233
payload:
type: char_string
defaultValue: "MT:-24J0AFN00KA0648G00" # This value needs to be generated automatically
Expand All @@ -41,6 +38,14 @@ tests:
- name: "nodeId"
value: nodeId

- label: "Read the commissioner node ID"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
response:
values:
- name: "nodeId"
saveAs: CommissionerNodeId

- label:
"TH1 reads OperationalCredentials cluster CurrentFabricIndex attribute"
command: "readAttribute"
Expand Down Expand Up @@ -116,7 +121,7 @@ tests:
- label:
"Step 7:TH1 reads DUT Endpoint 0 AccessControl cluster
SubjectsPerAccessControlEntry attribute"
PICS: ACL.S.A0001
PICS: ACL.S.A0002
command: "readAttribute"
attribute: "SubjectsPerAccessControlEntry"
response:
Expand All @@ -126,7 +131,7 @@ tests:
- label:
"Step 8:TH1 reads DUT Endpoint 0 AccessControl cluster
TargetsPerAccessControlEntry attribute"
PICS: ACL.S.A0001
PICS: ACL.S.A0003
command: "readAttribute"
attribute: "TargetsPerAccessControlEntry"
response:
Expand All @@ -136,7 +141,7 @@ tests:
- label:
"Step 9:TH1 reads DUT Endpoint 0 AccessControl cluster
AccessControlEntriesPerFabric attribute"
PICS: ACL.S.A0001
PICS: ACL.S.A0004
command: "readAttribute"
attribute: "AccessControlEntriesPerFabric"
response:
Expand Down
5 changes: 0 additions & 5 deletions src/app/tests/suites/certification/Test_TC_ACT_2_2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ config:
tests:
- label: "Commission DUT to TH (can be skipped if done in a preceding test)"
verification: |
On DUT side:
sudo ./chip-bridge-app


On TH side:
./chip-tool pairing ethernet 1 20202021 3840 fe80::e65f:1ff:fe0f:2753 5540
disabled: true

- label:
Expand Down
12 changes: 0 additions & 12 deletions src/app/tests/suites/certification/Test_TC_BRBINFO_2_3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -213,18 +213,6 @@ tests:
[1663583922.989709][155023:155023] CHIP:DMG: << from UDP:[fe80::e2a:f0a6:5d44:15b1%wlp3s0]:35251 | 43255988 | [Secure Channel (0) / Standalone Ack (0x10) / Session = 0 / Exchange = 14682]
disabled: true

- label: "DUT reads Location from the TH"
PICS: BRBINFO.C.A0006
verification: |
./chip-tool bridgeddevicebasic read location 1 3

Optional Attribute - If it is supported, then in TH(bridge-app) log it will results in displaying the ReportDataMessage , else it will display UNSUPPORTED_ATTRIBUTE



chip-tool needs to be implemented
disabled: true

- label: "DUT reads HardwareVersion from the TH"
PICS: BRBINFO.C.A0007
verification: |
Expand Down
4 changes: 3 additions & 1 deletion src/app/tests/suites/certification/Test_TC_CADMIN_1_15.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ tests:
verification: |
Using TH_CR2 read attribute

./chip-tool basic read node-label 2 0 --commissioner-name beta
Verify read command fail as expected since the DUT_CE is no longer on the network on TH_CR2 (chip-tool) side

./chip-tool basicinformation read node-label 2 0 --commissioner-name beta

Received error (protocol code 2) during pairing process. ../../third_party/connectedhomeip/src/protocols/secure_channel/CASESession.cpp:1551: CHIP Error 0x00000054: Invalid CASE parameter
[1651819620.929567][4359:4364] CHIP:CTL: OperationalDeviceProxy[B8070CD13C99D367:0000000000000002]: State change 3 --> 2
Expand Down
4 changes: 3 additions & 1 deletion src/app/tests/suites/certification/Test_TC_CADMIN_1_16.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ tests:
verification: |
Using TH_CR2 read attribute

./chip-tool basic read node-label 2 0 --commissioner-name beta
Verify read command fail as expected since the DUT_CE is no longer on the network on TH_CR2 (chip-tool) log

./chip-tool basicinformation read node-label 2 0 --commissioner-name beta

Received error (protocol code 2) during pairing process. ../../third_party/connectedhomeip/src/protocols/secure_channel/CASESession.cpp:1551: CHIP Error 0x00000054: Invalid CASE parameter
[1651819620.929567][4359:4364] CHIP:CTL: OperationalDeviceProxy[B8070CD13C99D367:0000000000000002]: State change 3 --> 2
Expand Down
81 changes: 0 additions & 81 deletions src/app/tests/suites/certification/Test_TC_CGEN_2_4.yaml

This file was deleted.

5 changes: 3 additions & 2 deletions src/app/tests/suites/certification/Test_TC_G_2_2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ tests:
[1674543469.444257][19260:19262] CHIP:TOO: MaxGroupsPerFabric: 4
disabled: true

- label: "Precondition: If maxgroups>1, proceed with the following steps
- label: |
Precondition: If maxgroups>1, proceed with the following steps,

TH generates fabric-unique GroupID, GroupName, random key, EpochKey0
and GroupKeySetID.
Expand All @@ -66,7 +67,7 @@ tests:

TH binds GroupId(0x0001 to (maxgroups+1)) with GroupKeySetID in the
GroupKeyMap attribute list on GroupKeyManagement cluster with the
values provided in the above steps"
values provided in the above steps
verification: |
Execute the following command in TH to generate the pre-condition to execute this test case:

Expand Down
Loading