-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Handle uncaught exceptions before JNI crashes app and make iOS discoverCommissioners API callback based #24896
Merged
yufengwangca
merged 3 commits into
project-chip:master
from
sharadb-amazon:fixes-20230206
Feb 9, 2023
Merged
tv-casting-app: Handle uncaught exceptions before JNI crashes app and make iOS discoverCommissioners API callback based #24896
yufengwangca
merged 3 commits into
project-chip:master
from
sharadb-amazon:fixes-20230206
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
force-pushed
the
fixes-20230206
branch
from
February 7, 2023 02:14
f02e9cd
to
eb71bf7
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
February 7, 2023 02:15
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
February 7, 2023 02:15
PR #24896: Size comparison from eaa7476 to eb71bf7 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
chrisdecenzo
approved these changes
Feb 7, 2023
examples/tv-casting-app/android/App/app/src/main/jni/com/chip/casting/SuccessCallback.java
Outdated
Show resolved
Hide resolved
PR #24896: Size comparison from eaa7476 to 9602c19 Full report (1 build for cc32xx)
|
andy31415
approved these changes
Feb 8, 2023
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Feb 13, 2023
… make iOS discoverCommissioners API callback based (project-chip#24896) * iOS tv-casting-app: Making discovery API callback based * tv-casting-app: Handled uncaught exceptions and null pointer issues * Changing catch-all to catch Throwable instead of just Exception
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
… make iOS discoverCommissioners API callback based (project-chip#24896) * iOS tv-casting-app: Making discovery API callback based * tv-casting-app: Handled uncaught exceptions and null pointer issues * Changing catch-all to catch Throwable instead of just Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24895 and #24894
Problems fixed
Testing
Tested with the android and iOS tv-casting-apps