-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cache for the FindBinary method of scripts/tests/run_test_suite… #24882
Add a cache for the FindBinary method of scripts/tests/run_test_suite… #24882
Conversation
PR #24882: Size comparison from a85fe60 to 42adf66 Increases (7 builds for esp32, psoc6, telink)
Decreases (10 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
….py in order to not wait for too long each time it is runned manually
42adf66
to
4ba6e2c
Compare
PR #24882: Size comparison from 5eb5d91 to 4ba6e2c Increases (2 builds for psoc6, telink)
Decreases (4 builds for esp32, nrfconnect, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, however I also wonder if we could make the app path some sort of a lazy object ... if I run some tests, I may only need chip-tool + all-clusters and having to provide all other apps every time is annoying (and if I never built them, the cache probably is not useful as no file ever matches).
….py in order to not wait for too long each time it is runned manually (project-chip#24882)
….py in order to not wait for too long each time it is runned manually
Problem
Running
./scripts/tests/run_test_suite.py
search the disks for binaries every time. On my laptop it takes something like 30 seconds every time. This PR adds a cache such that it instantaneous the next time.Entries are evicted from the cache if the file does not exists anymore.