-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add a config_override property to the TestParser i… #24869
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_AddConfigOverride
Feb 7, 2023
Merged
[matter_yamltests] Add a config_override property to the TestParser i… #24869
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_AddConfigOverride
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24869: Size comparison from 655d134 to 1d810bb Increases (8 builds for bl602, efr32, psoc6, qpg, telink)
Decreases (6 builds for bl602, bl702, k32w, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Feb 6, 2023
vivien-apple
force-pushed
the
YamlTests_AddConfigOverride
branch
from
February 6, 2023 21:28
1d810bb
to
c14e546
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 6, 2023 21:29
pullapprove
bot
requested review from
LuDuda,
msandstedt,
pjzander-signify,
saurabhst,
selissia,
tecimovic,
vijs,
woody-apple and
xylophone21
February 6, 2023 21:29
PR #24869: Size comparison from 5eb5d91 to c14e546 Increases (13 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 6, 2023
…n order to modify the test parameters
vivien-apple
force-pushed
the
YamlTests_AddConfigOverride
branch
from
February 7, 2023 08:08
c14e546
to
142eab3
Compare
PR #24869: Size comparison from 8d801e8 to 142eab3 Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…n order to modify the test parameters (project-chip#24869)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n order to modify the test parameters
Problem
There is no mechanism to override the test configuration. The current
TestParser.update_config method does not provide the right abstraction since it appears that
YamlTests` does a deep copy of the config at init, so changing them after does not works.