-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Update data model lighting-app #24856
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:silab_template_update
Feb 7, 2023
Merged
[Silabs] Update data model lighting-app #24856
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:silab_template_update
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24856: Size comparison from 1832750 to 2ab74c7 Increases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (4 builds for efr32, esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Feb 3, 2023
jepenven-silabs
force-pushed
the
silab_template_update
branch
from
February 6, 2023 13:53
2ab74c7
to
92a3fd8
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
February 6, 2023 13:53
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
tcarmelveilleux,
turon,
vijs,
vivien-apple and
woody-apple
February 6, 2023 13:53
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
February 6, 2023 13:53
PR #24856: Size comparison from 5c8ae45 to 92a3fd8 Increases (5 builds for bl702, esp32, nrfconnect, telink)
Decreases (6 builds for bl602, efr32, nrfconnect, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jepenven-silabs
force-pushed
the
silab_template_update
branch
from
February 6, 2023 21:26
92a3fd8
to
f47c7ec
Compare
andy31415
reviewed
Feb 6, 2023
andy31415
approved these changes
Feb 6, 2023
PR #24856: Size comparison from 5eb5d91 to f47c7ec Increases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, efr32, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to platform specific Data Model to save some code size.
Changes :
Removed Thread diagnostic from WiFi and WiFi diagnostic from Thread
Removed Occupancy Sensing from both zap files
Code size reduction: ~7k for OpenThread Lighting-App.