-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fix LCD specific app image not getting compiled #24825
Merged
jmartinez-silabs
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix_lcd_appui
Feb 3, 2023
Merged
[Silabs] Fix LCD specific app image not getting compiled #24825
jmartinez-silabs
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix_lcd_appui
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
pjzander-signify
February 2, 2023 15:58
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 2, 2023 15:58
andy31415
approved these changes
Feb 2, 2023
arkq
approved these changes
Feb 2, 2023
lpbeliveau-silabs
approved these changes
Feb 2, 2023
PR #24825: Size comparison from 79d5ac4 to 94ab283 Increases (8 builds for bl602, esp32, psoc6, qpg, telink)
Decreases (3 builds for bl702, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
force-pushed
the
fix_lcd_appui
branch
from
February 3, 2023 14:57
94ab283
to
f79ea30
Compare
PR #24825: Size comparison from 87e7510 to f79ea30 Increases (7 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR 24742 reworking silabs build struture didn't compile the LCD specific app image.
Remove the conditional definitions with #ifdef logic
The LCD specifc app image is now defined directly in the
appConfig
header of the related sample app.Also the path to the
efr_matter_shell
source_set needed to be updated.