-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add force-write to allow writing to non-writable attributes #24788
Merged
andy31415
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_AddWriteOverride
Feb 2, 2023
Merged
[chip-tool] Add force-write to allow writing to non-writable attributes #24788
andy31415
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_AddWriteOverride
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns and
msandstedt
February 1, 2023 18:12
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
February 1, 2023 18:12
andy31415
reviewed
Feb 1, 2023
bzbarsky-apple
approved these changes
Feb 1, 2023
vivien-apple
force-pushed
the
ChipTool_AddWriteOverride
branch
from
February 1, 2023 19:36
25e0582
to
91b9a0d
Compare
vivien-apple
changed the title
[chip-tool] Add write-override to allow writing to non-writable attributes
[chip-tool] Add force-write to allow writing to non-writable attributes
Feb 1, 2023
andy31415
reviewed
Feb 1, 2023
bzbarsky-apple
approved these changes
Feb 1, 2023
PR #24788: Size comparison from 671d25c to 91b9a0d Increases above 0.2%:
Increases (10 builds for bl702, cc13x2_26x2, linux, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipTool_AddWriteOverride
branch
from
February 2, 2023 08:28
91b9a0d
to
1bedd2b
Compare
PR #24788: Size comparison from cd919db to 1bedd2b Increases above 0.2%:
Increases (12 builds for bl602, bl702, linux, psoc6, telink)
Decreases (5 builds for esp32, psoc6, qpg)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Feb 2, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…es (project-chip#24788) * [chip-tool] Add write-override to allow writing to non-writable attributes * Update generated chip-tool commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
does not generates anywrite attribute-name
method for attributes that are not writable. In some cases, we would like to check that the SDK returnsUNSUPPORTED_WRITE
. While it can be achieved withwrite-by-id attribute-id
, this is much more complex sincewrite-by-id
is agnostic of the type and expects a "custom" type formatted as json.This PR adds
write-override
command supports tochip-tool
for attributes that are not supposed to be writable.For the record, I need it for the python bridge, but I would expect some people from the certification process to find that useful too.