Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add missing RemoteDataModelLogger::LogEventAsJson call #24782

Merged
merged 1 commit into from
Feb 1, 2023
Merged

[chip-tool] Add missing RemoteDataModelLogger::LogEventAsJson call #24782

merged 1 commit into from
Feb 1, 2023

Conversation

vivien-apple
Copy link
Contributor

Problem

Events are not logged and forwarded over the wire by the RemoteDataModelLogger. This PR just add the missing line...

@vivien-apple vivien-apple self-assigned this Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited
Loading

PR #24782: Size comparison from 25df49b to d8d190b

Increases (7 builds for cc13x2_26x2, esp32, linux, psoc6, telink)
platform target config section 25df49b d8d190b change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660175 660183 8 0.0
.text 556920 556928 8 0.0
esp32 all-clusters-app c3devkit (read only) 1042100 1042102 2 0.0
.flash.text 1042100 1042102 2 0.0
linux chip-tool-ipv6only arm64 (read only) 11063484 11064028 544 0.0
.text 8814244 8814788 544 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063754 27063756 2 0.0
light cy8ckit_062s2_43012 .debug_info 22491179 22491180 1 0.0
telink light-switch-app tlsr9518adk80d text 592902 592906 4 0.0
lighting-app tlsr9518adk80d (read/write) 950484 950492 8 0.0
text 658298 658302 4 0.0
Decreases (9 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
platform target config section 25df49b d8d190b change % change
bl602 lighting-app bl602 .text 1022526 1022524 -2 -0.0
bl602+rpc (read/write) 1390938 1390930 -8 -0.0
.text 1053460 1053456 -4 -0.0
bl702 lighting-app bl702 .debug_info 40197534 40197533 -1 -0.0
.text 951566 951564 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183680 183672 -8 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 763564 763560 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27506003 27506002 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22711598 22711596 -2 -0.0
qpg lock-app qpg6105+debug (read/write) 1115408 1115400 -8 -0.0
.text 562504 562496 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 647800 647798 -2 -0.0
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 25df49b d8d190b change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022526 1022524 -2 -0.0
bl602+rpc (read/write) 1390938 1390930 -8 -0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053460 1053456 -4 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549875 1549875 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490964 490964 0 0.0
.debug_info 40197534 40197533 -1 -0.0
.debug_line 5265819 5265819 0 0.0
.debug_loc 3400392 3400392 0 0.0
.debug_ranges 371624 371624 0 0.0
.debug_str 3534818 3534818 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951566 951564 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698271 1698271 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518668 518668 0 0.0
.debug_info 44594116 44594116 0 0.0
.debug_line 5664170 5664170 0 0.0
.debug_loc 3596502 3596502 0 0.0
.debug_ranges 395328 395328 0 0.0
.debug_str 3938127 3938127 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028588 1028588 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660175 660183 8 0.0
(read/write) 183680 183672 -8 -0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556920 556928 8 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583898 0 0.0
.app_xip_area 460652 460652 0 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037404 1037404 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853712 853712 0 0.0
BRD4187C (read/write) 1150156 1150156 0 0.0
.bss 132916 132916 0 0.0
.data 2544 2544 0 0.0
.text 990100 990100 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065044 1065044 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909824 909824 0 0.0
window-app BRD4187C (read/write) 1145052 1145052 0 0.0
.bss 134428 134428 0 0.0
.data 2572 2572 0 0.0
.text 983456 983456 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042100 1042102 2 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042100 1042102 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497823 497823 0 0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248900 248900 0 0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659420 659420 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561572 561572 0 0.0
light k32w0+release (read/write) 671420 671420 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592220 592220 0 0.0
lock k32w0+release (read/write) 630800 630800 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550812 550812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11063484 11064028 544 0.0
(read/write) 704776 704776 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648200 648200 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576284 576284 0 0.0
.text 8814244 8814788 544 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763560 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27506003 27506002 -1 -0.0
.debug_line 3778996 3778996 0 0.0
.debug_loc 3673164 3673164 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 0 0 0 0.0
1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063754 27063756 2 0.0
.debug_line 3787362 3787362 0 0.0
.debug_loc 3656895 3656895 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491179 22491180 1 0.0
.debug_line 3340167 3340167 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645188 1645188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073262 1073262 0 0.0
.debug_aranges 103192 103192 0 0.0
.debug_frame 348448 348448 0 0.0
.debug_info 22711598 22711596 -2 -0.0
.debug_line 3341772 3341772 0 0.0
.debug_loc 3357821 3357821 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3291255 3291255 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477035 477035 0 0.0
.symtab 379504 379504 0 0.0
.text 1448416 1448416 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115400 -8 -0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562496 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015280 1015280 0 0.0
bss 98044 98044 0 0.0
text 685418 685418 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647800 647798 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857388 857388 0 0.0
bss 89216 89216 0 0.0
text 578780 578780 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592902 592906 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950484 950492 8 0.0
bss 97452 97452 0 0.0
text 658298 658302 4 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887328 0 0.0
bss 90252 90252 0 0.0
text 604272 604272 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594480 594480 0 0.0

@vivien-apple vivien-apple merged commit fa8fa15 into project-chip:master Feb 1, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[chip-tool] Add missing RemoteDataModelLogger::LogEventAsJson call (p…
526bdbf 
…roject-chip#24782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tehampson tehampson tehampson approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @tehampson @bzbarsky-apple