[Hotfix] Fix ot-br-posix crash in cirque #24773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
yunhanw-google
approved these changes
Feb 1, 2023
bzbarsky-apple
approved these changes
Feb 1, 2023
|
PR #24773: Size comparison from 34332ce to 3f0ffa0 Full report (3 builds for mbed, qpg)
|
erjiaqing
force-pushed
the
hotfix-20230201
branch
from
3f0ffa0 to
607118c
Compare
|
PR #24773: Size comparison from 8dc9323 to 607118c Increases (4 builds for esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@erjiaqing - could you update in the summary what the fix was? There is no obvious change of |
|
PR #24773: Size comparison from 8dc9323 to c32be54 Increases (3 builds for esp32, telink)
Decreases (7 builds for bl702, esp32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
erjiaqing
force-pushed
the
hotfix-20230201
branch
from
c32be54 to
2271661
Compare
|
PR #24773: Size comparison from 8dc9323 to 2271661 Increases (2 builds for bl602, psoc6)
Decreases (6 builds for bl702, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Merged
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [Hotfix] Fix ot-br-posix crash in cirque * Restyled by shellharden * Fix * Update ot-br-posix for mDNS Responder source name * Specify infra interface when starting ot-br-agent --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24772
When running Cirque Bootstrap in Docker, we cannot fetch the expected checkout of ot-br-posix due to warnings (and becomes a fatal error) of git.
This makes the script always fetch the latest revision of ot-br-posix, and the test becomes unstable.
This PR will bypass the warning of git by adding the repo to git safe directory.
mDNSResponder, this PR pulls the updated ot-br-posix so the CI can pass.eth0(default backbone interface of docker)