Call stopControllerFactory atexit in the Darwin framework. #24767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #24767: Size comparison from 02f35ec to 5afad08 Increases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, qpg, telink)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (29 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
We have lots of things with static destructors that assert clean shutdown in the destructor. That means that calling exit() without a clean shutdown is pretty much guaranteed to lead to a shutdown crash. Just ensure that we are in fact shutting down the MTRDeviceControllerFactory if exit() is called, to avoid those crashes. Fixes project-chip#14859
bzbarsky-apple
force-pushed
the
clean-shutdown-controller-factory-on-exit
branch
from
5afad08 to
6820651
Compare
|
PR #24767: Size comparison from 02f35ec to 6820651 Increases (8 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, qpg)
Decreases (7 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
woody-apple
approved these changes
Feb 1, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…hip#24767) We have lots of things with static destructors that assert clean shutdown in the destructor. That means that calling exit() without a clean shutdown is pretty much guaranteed to lead to a shutdown crash. Just ensure that we are in fact shutting down the MTRDeviceControllerFactory if exit() is called, to avoid those crashes. Fixes project-chip#14859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have lots of things with static destructors that assert clean shutdown in the destructor. That means that calling exit() without a clean shutdown is pretty much guaranteed to lead to a shutdown crash.
Just ensure that we are in fact shutting down the
MTRDeviceControllerFactory if exit() is called, to avoid those crashes.