-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Try to not convert strings that represent a variab… #24751
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_DoNotAssumeUnrepresentableIntegersAreAlwaysIntegerStrings
Jan 31, 2023
Merged
[matter_yamltests] Try to not convert strings that represent a variab… #24751
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_DoNotAssumeUnrepresentableIntegersAreAlwaysIntegerStrings
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le in try_apply_yaml_unrepresentable_integer_for_javascript_fixes
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
January 31, 2023 10:22
pullapprove
bot
requested review from
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 31, 2023 10:22
PR #24751: Size comparison from 210ae33 to 606ea12 Increases (7 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, k32w, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Jan 31, 2023
bzbarsky-apple
approved these changes
Jan 31, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…le in try_apply_yaml_unrepresentable_integer_for_javascript_fixes (project-chip#24751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le in try_apply_yaml_unrepresentable_integer_for_javascript_fixes
Problem
The
matter_yamltests
parser assume that unrepresentable integers as strings (to workaround some javascript limitations) and try to convert such strings toint
. That is fine, but sometimes the string is just a variable, and we should not convert it (or throw).It notably happens for
TestCommissionerNodeId.yaml
which I am currently trying to enable...