[Silabs] Refactor/Cleanup examples build files #24742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #24742: Size comparison from cdaa392 to 4b85113 Increases (6 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Decreases (12 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
force-pushed
the
cleanup_build_files
branch
2 times, most recently
from
f7f6da1 to
2f8a530
Compare
|
PR #24742: Size comparison from 27ac945 to 2f8a530 Increases (9 builds for cc13x2_26x2, efr32, esp32, k32w, nrfconnect, qpg, telink)
Decreases (16 builds for bl602, bl702, efr32, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
selissia
approved these changes
Jan 31, 2023
tcarmelveilleux
approved these changes
Feb 1, 2023
…t. Move some build args to better/generic locations to reduce code duplication and build system complexity. Lighting-app mainly done
…p. Fix thread lib build with new gsdk
…tor will come at another time Remove a Todo. It is not needed remove extra bracket in chef's build.gn
Fix lock-rpc build
jmartinez-silabs
force-pushed
the
cleanup_build_files
branch
from
2f8a530 to
bbdd89f
Compare
|
PR #24742: Size comparison from 157f2b3 to bbdd89f Increases (13 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, efr32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Merged
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* WIP : Move common example platform source files to a common source_set. Move some build args to better/generic locations to reduce code duplication and build system complexity. Lighting-app mainly done * Bring efr32_common to the others efr32 efr32 app and some more cleanup. Fix thread lib build with new gsdk * WIP WiFi build cleanup. Rs911x Lighting-app builds * WIP more clean up for wifi platform. wf200 now builds lighting app * Apply refactore to the other examples builg.gn * Fix window_app build for wifi, fix thermostat build.gn. fix test_driver build * Fix so SiWx917 platform builds with the efr32 refactor. SiWx917 Refactor will come at another time Remove a Todo. It is not needed remove extra bracket in chef's build.gn * fix build with pw rpc Fix lock-rpc build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silabs Sample apps GN build is convoluted and duplicates a lot of args and conditions in each example's
BUILD.gn.This PR aims to reduce this duplication, regroup board or sdk arguments, and common example platform sources building to a common location.
Platforms affected by the refactoring:
EFR32 MG12 or MG24 families thread apps
EFR32 + wf200 or rs9116 wifi RCP apps
SiWx917 platform still needs a cleanup. It will be done in a second phase. Only some arguments duplicated have been removed from its build.gn s.
Tested the build of all Silabs sample examples on the 4 platforms + tested a few different boards and configurations.