-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetCommissionerNodeId command supports for yaml tests, chip-tool and darwin-framework-tool #24737
Merged
vivien-apple
merged 3 commits into
project-chip:master
from
vivien-apple:YamlTest_UseGetCommissionerNodeIdStep
Feb 1, 2023
Merged
Add GetCommissionerNodeId command supports for yaml tests, chip-tool and darwin-framework-tool #24737
vivien-apple
merged 3 commits into
project-chip:master
from
vivien-apple:YamlTest_UseGetCommissionerNodeIdStep
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
January 30, 2023 18:26
pullapprove
bot
requested review from
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 30, 2023 18:26
vivien-apple
changed the title
Yaml test use get commissioner node id step
Add GetCommissionerNodeId command supports for yaml tests, chip-tool and darwin-framework-tool
Jan 30, 2023
andy31415
approved these changes
Jan 30, 2023
bzbarsky-apple
approved these changes
Jan 30, 2023
PR #24737: Size comparison from 35bd94d to c11826d Increases (9 builds for bl602, cc13x2_26x2, esp32, telink)
Decreases (10 builds for bl602, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
Merged
vivien-apple
force-pushed
the
YamlTest_UseGetCommissionerNodeIdStep
branch
from
February 1, 2023 09:46
c11826d
to
74e90a7
Compare
vivien-apple
force-pushed
the
YamlTest_UseGetCommissionerNodeIdStep
branch
from
February 1, 2023 10:05
74e90a7
to
baeb1c0
Compare
PR #24737: Size comparison from 25df49b to baeb1c0 Increases (7 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
YamlTest_UseGetCommissionerNodeIdStep
branch
2 times, most recently
from
February 1, 2023 15:12
4129347
to
df0dd2d
Compare
PR #24737: Size comparison from 157f2b3 to df0dd2d Increases (13 builds for bl602, cc13x2_26x2, efr32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, linux, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
YamlTest_UseGetCommissionerNodeIdStep
branch
from
February 1, 2023 16:44
df0dd2d
to
b9772b2
Compare
PR #24737: Size comparison from fa8fa15 to b9772b2 Increases (10 builds for bl602, cc13x2_26x2, linux, psoc6, telink)
Decreases (16 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…and darwin-framework-tool (project-chip#24737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#24197 has introduced a variable named
commissionedNodeId
for yaml that is directly exposed by the Test Harness. That diverge from the other YAML steps that normally use pseudo-clusters commands in order to do things.commissionerNodeId
is used in various tests now, so this PR replace the inner variable mechanism by exposing a new pseudo-cluster command (CommissionerCommands::GetCommissionerNodeId
) where the value retrieved is saved and reused in the steps that needs it.This PR requires a ZAP update but it can be reviewed before the ZAP update lands (for the record, the necessary ZAP change is in project-chip/zap#910)