Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we stop resolves triggered by a browse when the browse stops on Darwin. #24733

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Without this change, if there is a PTR record that matches whatever we are browsing but no corresponding SRV record, we would end up leaking a resolve forever.

Tested by modifying minimal mdns SrvResponder::AddAllResponses to no-op instead of actually adding any responses, then trying to commission the device running the modified minimal mdns. Without this change, when the browse stops the resolves it triggered keep going. With this change, termination of the browse also terminates the resolves.

Fixes #24074

…s on Darwin.

Without this change, if there is a PTR record that matches whatever we are
browsing but no corresponding SRV record, we would end up leaking a resolve
forever.

Tested by modifying minimal mdns SrvResponder::AddAllResponses to no-op instead
of actually adding any responses, then trying to commission the device running
the modified minimal mdns.  Without this change, when the browse stops the
resolves it triggered keep going.  With this change, termination of the browse
also terminates the resolves.

Fixes project-chip#24074
@vivien-apple
Copy link
Contributor

The static sContextDispatchingSuccess is ...
Sadly I don’t have anything better to propose since I don’t have a good idea about how to to keep track of the original browse using the platform API abstraction 😞
And so the magic happens because the context got cleared when ChipDnssdStopBrowse happens ?

@bzbarsky-apple
Copy link
Contributor Author

And so the magic happens because the context got cleared when ChipDnssdStopBrowse happens ?

Exactly. That shuts down all the things sharing that connection.

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

PR #24733: Size comparison from 0e896b4 to 9a71775

Increases (7 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
platform target config section 0e896b4 9a71775 change % change
bl702 lighting-app bl702 .debug_info 40198120 40198121 1 0.0
.text 952354 952356 2 0.0
cc13x2_26x2 shell LP_CC2652R7 (read only) 668550 668558 8 0.0
.text 584032 584040 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550814 550822 8 0.0
.app_xip_area 432320 432328 8 0.0
esp32 all-clusters-app m5stack (read/write) 497823 497827 4 0.0
.flash.rodata 248900 248904 4 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 763632 763636 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22711758 22711759 1 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1016676 1016684 8 0.0
text 686128 686130 2 0.0
Decreases (9 builds for bl602, cc13x2_26x2, cyw30739, k32w, psoc6, telink)
platform target config section 0e896b4 9a71775 change % change
bl602 lighting-app bl602+rpc .text 1053456 1053454 -2 -0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 185504 185496 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585458 585450 -8 -0.0
.app_xip_area 461476 461468 -8 -0.0
k32w light k32w0+release (read/write) 672884 672868 -16 -0.0
.text 592948 592932 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27505917 27505916 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22491101 22491100 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 953344 953336 -8 -0.0
text 648512 648508 -4 -0.0
contact-sensor-app tlsr9518adk80d text 579490 579486 -4 -0.0
lighting-app tlsr9518adk80d text 659010 659008 -2 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0e896b4 9a71775 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022522 0 0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053456 1053454 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184951 1184951 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549986 1549986 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490996 490996 0 0.0
.debug_info 40198120 40198121 1 0.0
.debug_line 5267150 5267150 0 0.0
.debug_loc 3401859 3401859 0 0.0
.debug_ranges 371928 371928 0 0.0
.debug_str 3535090 3535090 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571692 571692 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952354 952356 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698382 1698382 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518700 518700 0 0.0
.debug_info 44594412 44594412 0 0.0
.debug_line 5665475 5665475 0 0.0
.debug_loc 3597998 3597998 0 0.0
.debug_ranges 395632 395632 0 0.0
.debug_str 3938399 3938399 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632289 632289 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029342 1029342 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677311 677311 0 0.0
(read/write) 174672 174672 0 0.0
.bss 81676 81676 0 0.0
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589524 589524 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641391 641391 0 0.0
(read/write) 158368 158368 0 0.0
.bss 80868 80868 0 0.0
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 563648 563648 0 0.0
lock-ftd LP_CC2652R7 (read only) 674379 674379 0 0.0
(read/write) 174948 174948 0 0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597632 597632 0 0.0
lock-mtd LP_CC2652R7 (read only) 660727 660727 0 0.0
(read/write) 183864 183864 0 0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557512 557512 0 0.0
pump-app LP_CC2652R7 (read only) 687443 687443 0 0.0
(read/write) 162612 162612 0 0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596568 596568 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672875 672875 0 0.0
(read/write) 177292 177292 0 0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585920 585920 0 0.0
shell LP_CC2652R7 (read only) 668550 668558 8 0.0
(read/write) 185504 185496 -8 -0.0
.bss 83748 83748 0 0.0
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 584032 584040 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585458 585450 -8 -0.0
.app_xip_area 461476 461468 -8 -0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589182 589182 0 0.0
.app_xip_area 459904 459904 0 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550814 550822 8 0.0
.app_xip_area 432320 432328 8 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974160 974160 0 0.0
.bss 147152 147152 0 0.0
.data 2196 2196 0 0.0
.text 824792 824792 0 0.0
BRD4161A+rs911x (read/write) 1037212 1037212 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853520 853520 0 0.0
BRD4187C (read/write) 1151328 1151328 0 0.0
.bss 133652 133652 0 0.0
.data 2544 2544 0 0.0
.text 990536 990536 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064836 1064836 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909616 909616 0 0.0
window-app BRD4187C (read/write) 1146240 1146240 0 0.0
.bss 135164 135164 0 0.0
.data 2572 2572 0 0.0
.text 983908 983908 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042096 1042096 0 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042096 1042096 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497823 497827 4 0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248900 248904 4 0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660940 660940 0 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562356 562356 0 0.0
light k32w0+release (read/write) 672884 672868 -16 -0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592948 592932 -16 -0.0
lock k32w0+release (read/write) 632320 632320 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551596 551596 0 0.0
linux all-clusters-app debug (read only) 3154921 3154921 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283659 283659 0 0.0
.text 2685842 2685842 0 0.0
all-clusters-minimal-app debug (read only) 2971193 2971193 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282379 282379 0 0.0
.text 2506722 2506722 0 0.0
bridge-app debug (read only) 2524809 2524809 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138498 2138498 0 0.0
chip-tool debug (read only) 11667073 11667073 0 0.0
(read/write) 648720 648720 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 612656 612656 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 650117 650117 0 0.0
.text 9514196 9514196 0 0.0
chip-tool-ipv6only arm64 (read only) 11041660 11041660 0 0.0
(read/write) 698024 698024 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 641448 641448 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576188 576188 0 0.0
.text 8812772 8812772 0 0.0
lighting-app debug+rpc (read only) 2692241 2692241 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2285026 2285026 0 0.0
lock-app debug (read only) 2655033 2655033 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246088 246088 0 0.0
.text 2236434 2236434 0 0.0
ota-provider-app debug (read only) 2225041 2225041 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197416 197416 0 0.0
.text 1887106 1887106 0 0.0
ota-requestor-app debug (read only) 2386553 2386553 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032610 2032610 0 0.0
shell debug (read only) 2684385 2684385 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241746 241746 0 0.0
.text 2282194 2282194 0 0.0
thermostat-no-ble arm64 (read only) 2506604 2506604 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093920 2093920 0 0.0
tv-app debug (read only) 3314721 3314721 0 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2849474 2849474 0 0.0
tv-casting-app debug (read only) 5692681 5692681 0 0.0
(read/write) 162264 162264 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 100216 100216 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365332 365332 0 0.0
.text 5048690 5048690 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165296 1165296 0 0.0
bss 147246 147246 0 0.0
rodata 133352 133352 0 0.0
text 804472 804472 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366864 1366864 0 0.0
bss 106546 106546 0 0.0
rodata 210832 210832 0 0.0
text 763632 763636 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1111544 1111544 0 0.0
bss 146402 146402 0 0.0
rodata 110496 110496 0 0.0
text 774544 774544 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27505917 27505916 -1 -0.0
.debug_line 3778983 3778983 0 0.0
.debug_loc 3673163 3673163 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485010 3485010 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 0 0 0 0.0
1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063668 27063668 0 0.0
.debug_line 3787349 3787349 0 0.0
.debug_loc 3656893 3656893 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470763 3470763 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491101 22491100 -1 -0.0
.debug_line 3340154 3340154 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274787 3274787 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645260 1645260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073378 1073378 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22711758 22711759 1 0.0
.debug_line 3341884 3341884 0 0.0
.debug_loc 3358062 3358062 0 0.0
.debug_ranges 321296 321296 0 0.0
.debug_str 3291194 3291194 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477007 477007 0 0.0
.symtab 379456 379456 0 0.0
.text 1448488 1448488 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148352 1148352 0 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595452 595452 0 0.0
lock-app qpg6105+debug (read/write) 1116056 1116056 0 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563152 563152 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1016676 1016684 8 0.0
bss 98776 98776 0 0.0
text 686128 686130 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953344 953336 -8 -0.0
bss 97824 97824 0 0.0
text 648512 648508 -4 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 858792 858792 0 0.0
bss 89948 89948 0 0.0
text 579490 579486 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874572 874572 0 0.0
bss 90036 90036 0 0.0
text 593614 593614 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951888 951888 0 0.0
bss 98184 98184 0 0.0
text 659010 659008 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888732 888732 0 0.0
bss 90984 90984 0 0.0
text 604982 604982 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878780 878780 0 0.0
bss 91424 91424 0 0.0
text 595190 595190 0 0.0

@bzbarsky-apple bzbarsky-apple marked this pull request as draft January 30, 2023 17:46
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review January 30, 2023 19:19
@github-actions
Copy link

github-actions bot commented Jan 30, 2023

PR #24733: Size comparison from cdaa392 to 571eb08

Increases (7 builds for bl602, cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section cdaa392 571eb08 change % change
bl602 lighting-app bl602+rpc (read/write) 1390930 1390938 8 0.0
.text 1053456 1053458 2 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660175 660183 8 0.0
.text 556920 556928 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583890 583898 8 0.0
.app_xip_area 460644 460652 8 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 763560 763564 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 773876 773880 4 0.0
telink all-clusters-app tlsr9518adk80d text 685418 685420 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 647798 647802 4 0.0
Decreases (12 builds for bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
platform target config section cdaa392 571eb08 change % change
bl702 lighting-app bl702+rpc .debug_info 44594117 44594116 -1 -0.0
.text 1028590 1028588 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183680 183672 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 497827 497823 -4 -0.0
.flash.rodata 248904 248900 -4 -0.0
k32w contact k32w0+release (read/write) 659420 659404 -16 -0.0
.text 561572 561556 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27506004 27506003 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063756 27063754 -2 -0.0
light cy8ckit_062s2_43012 .debug_info 22491181 22491179 -2 -0.0
telink contact-sensor-app tlsr9518adk80d text 578780 578778 -2 -0.0
light-switch-app tlsr9518adk80d text 592906 592902 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 950492 950484 -8 -0.0
text 658302 658298 -4 -0.0
ota-requestor-app tlsr9518adk80d text 604272 604270 -2 -0.0
thermostat tlsr9518adk80d text 594482 594478 -4 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section cdaa392 571eb08 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022524 1022524 0 0.0
bl602+rpc (read/write) 1390930 1390938 8 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053456 1053458 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549875 1549875 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490964 490964 0 0.0
.debug_info 40197534 40197534 0 0.0
.debug_line 5265819 5265819 0 0.0
.debug_loc 3400392 3400392 0 0.0
.debug_ranges 371624 371624 0 0.0
.debug_str 3534818 3534818 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951566 951566 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698271 1698271 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518668 518668 0 0.0
.debug_info 44594117 44594116 -1 -0.0
.debug_line 5664170 5664170 0 0.0
.debug_loc 3596502 3596502 0 0.0
.debug_ranges 395328 395328 0 0.0
.debug_str 3938127 3938127 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028590 1028588 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660175 660183 8 0.0
(read/write) 183680 183672 -8 -0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556920 556928 8 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583890 583898 8 0.0
.app_xip_area 460644 460652 8 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 972840 972840 0 0.0
.bss 146416 146416 0 0.0
.data 2196 2196 0 0.0
.text 824208 824208 0 0.0
BRD4161A+rs911x (read/write) 1037212 1037212 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853520 853520 0 0.0
BRD4187C (read/write) 1149932 1149932 0 0.0
.bss 132916 132916 0 0.0
.data 2544 2544 0 0.0
.text 989876 989876 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064836 1064836 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909616 909616 0 0.0
window-app BRD4187C (read/write) 1144844 1144844 0 0.0
.bss 134428 134428 0 0.0
.data 2572 2572 0 0.0
.text 983248 983248 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042100 1042100 0 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042100 1042100 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497827 497823 -4 -0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248904 248900 -4 -0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659420 659404 -16 -0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561572 561556 -16 -0.0
light k32w0+release (read/write) 671420 671420 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592220 592220 0 0.0
lock k32w0+release (read/write) 630800 630800 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550812 550812 0 0.0
linux all-clusters-app debug (read only) 3154937 3154937 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283659 283659 0 0.0
.text 2685858 2685858 0 0.0
all-clusters-minimal-app debug (read only) 2971209 2971209 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282379 282379 0 0.0
.text 2506738 2506738 0 0.0
bridge-app debug (read only) 2524825 2524825 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138514 2138514 0 0.0
chip-tool debug (read only) 11687793 11687793 0 0.0
(read/write) 655472 655472 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619408 619408 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 650341 650341 0 0.0
.text 9514436 9514436 0 0.0
chip-tool-ipv6only arm64 (read only) 11062220 11062220 0 0.0
(read/write) 704776 704776 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648200 648200 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576284 576284 0 0.0
.text 8812980 8812980 0 0.0
lighting-app debug+rpc (read only) 2692257 2692257 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2285042 2285042 0 0.0
lock-app debug (read only) 2655033 2655033 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246088 246088 0 0.0
.text 2236434 2236434 0 0.0
ota-provider-app debug (read only) 2225057 2225057 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197416 197416 0 0.0
.text 1887122 1887122 0 0.0
ota-requestor-app debug (read only) 2386569 2386569 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032626 2032626 0 0.0
shell debug (read only) 2684385 2684385 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241746 241746 0 0.0
.text 2282194 2282194 0 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
tv-app debug (read only) 3314737 3314737 0 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2849490 2849490 0 0.0
tv-casting-app debug (read only) 5699513 5699513 0 0.0
(read/write) 164568 164568 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102520 102520 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365268 365268 0 0.0
.text 5048626 5048626 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763560 763564 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773876 773880 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27506004 27506003 -1 -0.0
.debug_line 3778996 3778996 0 0.0
.debug_loc 3673164 3673164 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 0 0 0 0.0
1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063756 27063754 -2 -0.0
.debug_line 3787362 3787362 0 0.0
.debug_loc 3656895 3656895 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491181 22491179 -2 -0.0
.debug_line 3340167 3340167 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645260 1645260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073378 1073378 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22711837 22711837 0 0.0
.debug_line 3341897 3341897 0 0.0
.debug_loc 3358062 3358062 0 0.0
.debug_ranges 321296 321296 0 0.0
.debug_str 3291214 3291214 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477007 477007 0 0.0
.symtab 379456 379456 0 0.0
.text 1448488 1448488 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015280 1015280 0 0.0
bss 98044 98044 0 0.0
text 685418 685420 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647798 647802 4 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857388 857388 0 0.0
bss 89216 89216 0 0.0
text 578780 578778 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592906 592902 -4 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950492 950484 -8 -0.0
bss 97452 97452 0 0.0
text 658302 658298 -4 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887328 0 0.0
bss 90252 90252 0 0.0
text 604272 604270 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594482 594478 -4 -0.0

@bzbarsky-apple bzbarsky-apple marked this pull request as draft January 31, 2023 03:48
@bzbarsky-apple
Copy link
Contributor Author

bzbarsky-apple commented Jan 31, 2023

So the previous approach does not work because each ResolveContext expects to get an update without the "more coming" flag and acts on that, but if they are all sharing a connection only one of them will get such an update. Fixing that would involve the resolve contexts knowing about each other and the one that gets that flag triggering finalization on all the other ones too.

Since we have to track the ResolveContexts anyway to clean them up, I am going to go back to just having each one use a separate connection; it's less code and has the same effect in the end.

@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review January 31, 2023 13:19
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

PR #24733: Size comparison from 210ae33 to e41aedc

Increases (4 builds for bl602, esp32, psoc6, telink)
platform target config section 210ae33 e41aedc change % change
bl602 lighting-app bl602 .text 1022524 1022526 2 0.0
esp32 all-clusters-app c3devkit (read only) 1042098 1042100 2 0.0
.flash.text 1042098 1042100 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27506003 27506004 1 0.0
telink thermostat tlsr9518adk80d text 594478 594480 2 0.0
Decreases (3 builds for bl602, psoc6, telink)
platform target config section 210ae33 e41aedc change % change
bl602 lighting-app bl602+rpc (read/write) 1390938 1390930 -8 -0.0
.text 1053458 1053456 -2 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063756 27063755 -1 -0.0
telink light-switch-app tlsr9518adk80d text 592906 592904 -2 -0.0
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 210ae33 e41aedc change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022524 1022526 2 0.0
bl602+rpc (read/write) 1390938 1390930 -8 -0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053458 1053456 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549875 1549875 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490964 490964 0 0.0
.debug_info 40197533 40197533 0 0.0
.debug_line 5265819 5265819 0 0.0
.debug_loc 3400392 3400392 0 0.0
.debug_ranges 371624 371624 0 0.0
.debug_str 3534818 3534818 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951564 951564 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698271 1698271 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518668 518668 0 0.0
.debug_info 44594116 44594116 0 0.0
.debug_line 5664170 5664170 0 0.0
.debug_loc 3596502 3596502 0 0.0
.debug_ranges 395328 395328 0 0.0
.debug_str 3938127 3938127 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028588 1028588 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660183 660183 0 0.0
(read/write) 183672 183672 0 0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556928 556928 0 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583898 0 0.0
.app_xip_area 460652 460652 0 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042098 1042100 2 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042098 1042100 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497823 497823 0 0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248900 248900 0 0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659420 659420 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561572 561572 0 0.0
light k32w0+release (read/write) 671420 671420 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592220 592220 0 0.0
lock k32w0+release (read/write) 630800 630800 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550812 550812 0 0.0
linux all-clusters-app debug (read only) 3154937 3154937 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283659 283659 0 0.0
.text 2685858 2685858 0 0.0
all-clusters-minimal-app debug (read only) 2971209 2971209 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282379 282379 0 0.0
.text 2506738 2506738 0 0.0
bridge-app debug (read only) 2524825 2524825 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138514 2138514 0 0.0
chip-tool debug (read only) 11687793 11687793 0 0.0
(read/write) 655472 655472 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619408 619408 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 650341 650341 0 0.0
.text 9514436 9514436 0 0.0
chip-tool-ipv6only arm64 (read only) 11062220 11062220 0 0.0
(read/write) 704776 704776 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648200 648200 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576284 576284 0 0.0
.text 8812980 8812980 0 0.0
lighting-app debug+rpc (read only) 2692257 2692257 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2285042 2285042 0 0.0
lock-app debug (read only) 2655033 2655033 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246088 246088 0 0.0
.text 2236434 2236434 0 0.0
ota-provider-app debug (read only) 2225057 2225057 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197416 197416 0 0.0
.text 1887122 1887122 0 0.0
ota-requestor-app debug (read only) 2386569 2386569 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032626 2032626 0 0.0
shell debug (read only) 2684385 2684385 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241746 241746 0 0.0
.text 2282194 2282194 0 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
tv-app debug (read only) 3314737 3314737 0 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2849490 2849490 0 0.0
tv-casting-app debug (read only) 5699513 5699513 0 0.0
(read/write) 164568 164568 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102520 102520 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365268 365268 0 0.0
.text 5048626 5048626 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763564 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27506003 27506004 1 0.0
.debug_line 3778996 3778996 0 0.0
.debug_loc 3673164 3673164 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063756 27063755 -1 -0.0
.debug_line 3787362 3787362 0 0.0
.debug_loc 3656895 3656895 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491179 22491179 0 0.0
.debug_line 3340167 3340167 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645260 1645260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073378 1073378 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22711838 22711838 0 0.0
.debug_line 3341897 3341897 0 0.0
.debug_loc 3358062 3358062 0 0.0
.debug_ranges 321296 321296 0 0.0
.debug_str 3291214 3291214 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477007 477007 0 0.0
.symtab 379456 379456 0 0.0
.text 1448488 1448488 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015280 1015280 0 0.0
bss 98044 98044 0 0.0
text 685420 685420 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647800 647800 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857388 857388 0 0.0
bss 89216 89216 0 0.0
text 578780 578780 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592906 592904 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950492 950492 0 0.0
bss 97452 97452 0 0.0
text 658302 658302 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887328 0 0.0
bss 90252 90252 0 0.0
text 604272 604272 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594478 594480 2 0.0

@github-actions
Copy link

github-actions bot commented Jan 31, 2023

PR #24733: Size comparison from 210ae33 to 13ebed0

Increases (3 builds for esp32, psoc6, telink)
platform target config section 210ae33 13ebed0 change % change
esp32 all-clusters-app c3devkit (read only) 1042098 1042100 2 0.0
.flash.text 1042098 1042100 2 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22491179 22491181 2 0.0
telink thermostat tlsr9518adk80d text 594478 594482 4 0.0
Decreases (9 builds for bl602, bl702, psoc6, telink)
platform target config section 210ae33 13ebed0 change % change
bl602 lighting-app bl602 .text 1022524 1022522 -2 -0.0
bl702 lighting-app bl702 .debug_info 40197533 40197532 -1 -0.0
.text 951564 951562 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27506003 27506002 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063756 27063755 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22711838 22711836 -2 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1015280 1015272 -8 -0.0
text 685420 685416 -4 -0.0
contact-sensor-app tlsr9518adk80d text 578780 578778 -2 -0.0
light-switch-app tlsr9518adk80d text 592906 592904 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 950492 950484 -8 -0.0
text 658302 658298 -4 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 210ae33 13ebed0 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022524 1022522 -2 -0.0
bl602+rpc (read/write) 1390938 1390938 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053458 1053458 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549875 1549875 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490964 490964 0 0.0
.debug_info 40197533 40197532 -1 -0.0
.debug_line 5265819 5265819 0 0.0
.debug_loc 3400392 3400392 0 0.0
.debug_ranges 371624 371624 0 0.0
.debug_str 3534818 3534818 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951564 951562 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698271 1698271 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518668 518668 0 0.0
.debug_info 44594116 44594116 0 0.0
.debug_line 5664170 5664170 0 0.0
.debug_loc 3596502 3596502 0 0.0
.debug_ranges 395328 395328 0 0.0
.debug_str 3938127 3938127 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028588 1028588 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660183 660183 0 0.0
(read/write) 183672 183672 0 0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556928 556928 0 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583898 0 0.0
.app_xip_area 460652 460652 0 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 972840 972840 0 0.0
.bss 146416 146416 0 0.0
.data 2196 2196 0 0.0
.text 824208 824208 0 0.0
BRD4161A+rs911x (read/write) 1037212 1037212 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853520 853520 0 0.0
BRD4187C (read/write) 1149932 1149932 0 0.0
.bss 132916 132916 0 0.0
.data 2544 2544 0 0.0
.text 989876 989876 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064836 1064836 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909616 909616 0 0.0
window-app BRD4187C (read/write) 1144844 1144844 0 0.0
.bss 134428 134428 0 0.0
.data 2572 2572 0 0.0
.text 983248 983248 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042098 1042100 2 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042098 1042100 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497823 497823 0 0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248900 248900 0 0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659420 659420 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561572 561572 0 0.0
light k32w0+release (read/write) 671420 671420 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592220 592220 0 0.0
lock k32w0+release (read/write) 630800 630800 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550812 550812 0 0.0
linux all-clusters-app debug (read only) 3154937 3154937 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283659 283659 0 0.0
.text 2685858 2685858 0 0.0
all-clusters-minimal-app debug (read only) 2971209 2971209 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282379 282379 0 0.0
.text 2506738 2506738 0 0.0
bridge-app debug (read only) 2524825 2524825 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138514 2138514 0 0.0
chip-tool debug (read only) 11687793 11687793 0 0.0
(read/write) 655472 655472 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619408 619408 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 650341 650341 0 0.0
.text 9514436 9514436 0 0.0
chip-tool-ipv6only arm64 (read only) 11062220 11062220 0 0.0
(read/write) 704776 704776 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648200 648200 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576284 576284 0 0.0
.text 8812980 8812980 0 0.0
lighting-app debug+rpc (read only) 2692257 2692257 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2285042 2285042 0 0.0
lock-app debug (read only) 2655033 2655033 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246088 246088 0 0.0
.text 2236434 2236434 0 0.0
ota-provider-app debug (read only) 2225057 2225057 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197416 197416 0 0.0
.text 1887122 1887122 0 0.0
ota-requestor-app debug (read only) 2386569 2386569 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032626 2032626 0 0.0
shell debug (read only) 2684385 2684385 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241746 241746 0 0.0
.text 2282194 2282194 0 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
tv-app debug (read only) 3314737 3314737 0 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2849490 2849490 0 0.0
tv-casting-app debug (read only) 5699513 5699513 0 0.0
(read/write) 164568 164568 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102520 102520 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365268 365268 0 0.0
.text 5048626 5048626 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763564 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27506003 27506002 -1 -0.0
.debug_line 3778996 3778996 0 0.0
.debug_loc 3673164 3673164 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063756 27063755 -1 -0.0
.debug_line 3787362 3787362 0 0.0
.debug_loc 3656895 3656895 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491179 22491181 2 0.0
.debug_line 3340167 3340167 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645260 1645260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073378 1073378 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22711838 22711836 -2 -0.0
.debug_line 3341897 3341897 0 0.0
.debug_loc 3358062 3358062 0 0.0
.debug_ranges 321296 321296 0 0.0
.debug_str 3291214 3291214 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477007 477007 0 0.0
.symtab 379456 379456 0 0.0
.text 1448488 1448488 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015280 1015272 -8 -0.0
bss 98044 98044 0 0.0
text 685420 685416 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647800 647800 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857388 857388 0 0.0
bss 89216 89216 0 0.0
text 578780 578778 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592906 592904 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950492 950484 -8 -0.0
bss 97452 97452 0 0.0
text 658302 658298 -4 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887328 0 0.0
bss 90252 90252 0 0.0
text 604272 604272 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594478 594482 4 0.0

@yufengwangca yufengwangca merged commit d72050c into project-chip:master Jan 31, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-browse-resolve branch January 31, 2023 18:59
rawadhilal88 pushed a commit to sharadb-amazon/connectedhomeip that referenced this pull request Feb 22, 2023
…at fixes DNS-SD browsing

Add an API to stop a DNS-SD browse operation. (project-chip#22823)

* Add an API to stop a DNS-SD browse operation.

Most backends don't implement this yet. Darwin does, and no longer
stops Browse operations itself.

Fixes project-chip#19194

May provide a way toward fixing
project-chip#13275

* Address review comments.

* Address more review comments.

[darwin] Use DNSServiceReconfirmRecord for A and AAAA records to miti… (project-chip#23067)

* [Dnssd] Add ReconfirmRecord method to verify address that appears to be out of date

* [SetUpCodePairer] Ask Dnssd to reconfirm discovered addresses if connecting to them ends with a CHIP_ERROR_TIMEOUT

Fix Logging When Trying to Log Nullptr To Strings (project-chip#23604)

This PR attempts to identify all cases where %s specifiers in the logging APIs
(ChipLogError(), ChipLogProgress(), ChipLogDetail()) don't have a guaranteed
non-null string parameter.

In all identified cases the issue is fixed using StringOrNullMarker() helper
method to guarantee it doesn't happen.

Use the "right" byte-swapping function for port in Darwin DnssdImpl. (project-chip#23894)

The incoming port is in host byte order and we are converting to network byte
order, so should use htons (which happens to do the same thing as ntohs, so no
behavior change).

Co-authored-by: Andrei Litvin <[email protected]>

Add a way for Resolver consumers to cancel operational resolve attempts. (project-chip#24010)

* Add a way for Resolver consumers to cancel operational resolve attempts.

Adds a way for consumers to notify Resolver when they no longer care
about an operational resolve, so a Resolver implementation can keep
track of how many consumers are interested and stop work as desired if
no one is interested.

Fixes project-chip#23881

* Address review comments.

* Address review comments.

Make sure we stop resolves triggered by a browse when the browse stops on Darwin. (project-chip#24733)

* Make sure we stop resolves triggered by a browse when the browse stops on Darwin.

Without this change, if there is a PTR record that matches whatever we are
browsing but no corresponding SRV record, we would end up leaking a resolve
forever.

Tested by modifying minimal mdns SrvResponder::AddAllResponses to no-op instead
of actually adding any responses, then trying to commission the device running
the modified minimal mdns.  Without this change, when the browse stops the
resolves it triggered keep going.  With this change, termination of the browse
also terminates the resolves.

Fixes project-chip#24074

* Also avoid leaking ResolveContext instances.

* Fix handling of multiple interfaces.

* Address review comment.

Improve discovery logging on Darwin. (project-chip#24846)

1) Use progress, not detail, logging, because detail logging is not actually
   persisted in system logs.
2) Add logging to a few functions that were missing it.

Remove the address type argument from ResolveNodeId. (project-chip#24006)

All consumers were passing kAny in practice, and some of the backends
(e.g. minimal mdns) had no capability to filter by type anyway.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…s on Darwin. (project-chip#24733)

* Make sure we stop resolves triggered by a browse when the browse stops on Darwin.

Without this change, if there is a PTR record that matches whatever we are
browsing but no corresponding SRV record, we would end up leaking a resolve
forever.

Tested by modifying minimal mdns SrvResponder::AddAllResponses to no-op instead
of actually adding any responses, then trying to commission the device running
the modified minimal mdns.  Without this change, when the browse stops the
resolves it triggered keep going.  With this change, termination of the browse
also terminates the resolves.

Fixes project-chip#24074

* Also avoid leaking ResolveContext instances.

* Fix handling of multiple interfaces.

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure we clean up resolves started by a browse if they have not completed when the browse completes.
4 participants