[icd] Defer subscription resumption #24725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns and
msandstedt
|
PR #24725: Size comparison from 4f24db4 to 1c0e9b0 Increases (4 builds for esp32, linux, mbed)
Full report (5 builds for esp32, linux, mbed)
|
Damian-Nordic
force-pushed
the
defer-subscriptions
branch
from
1c0e9b0 to
4d51e00
Compare
|
PR #24725: Size comparison from 4f24db4 to 4d51e00 Increases (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (47 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 30, 2023
Damian-Nordic
force-pushed
the
defer-subscriptions
branch
from
4d51e00 to
1923a2c
Compare
|
PR #24725: Size comparison from 8dc9323 to 1923a2c Increases (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
Damian-Nordic
force-pushed
the
defer-subscriptions
branch
from
1923a2c to
fb57e28
Compare
|
PR #24725: Size comparison from 25df49b to fb57e28 Increases (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 1, 2023
Damian-Nordic
force-pushed
the
defer-subscriptions
branch
from
fb57e28 to
978427d
Compare
andy31415
approved these changes
Feb 1, 2023
|
PR #24725: Size comparison from 811ab2b to 978427d Increases (64 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LuDuda
approved these changes
Feb 2, 2023
On some platforms, DNS-SD initialization is asynchronous and any attempt to communicate with a peer node before that is completed must fail. Introduce kServerReady event that is emitted when all async initialization tasks are completed (currently, only DNS-SD) and resume persistent subscriptions in response to that event.
Damian-Nordic
force-pushed
the
defer-subscriptions
branch
from
978427d to
1880173
Compare
|
PR #24725: Size comparison from cd919db to 1880173 Increases (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [zephyr] Add Kconfig to enable persistent subscriptions * [icd] Defer subscription resumption On some platforms, DNS-SD initialization is asynchronous and any attempt to communicate with a peer node before that is completed must fail. Introduce kServerReady event that is emitted when all async initialization tasks are completed (currently, only DNS-SD) and resume persistent subscriptions in response to that event. * Code review * Code review p.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms, DNS-SD initialization is asynchronous and any attempt to communicate with a peer node before that is completed must fail.
Introduce
kServerReadyevent that is emitted when all async initialization tasks are completed (currently, only DNS-SD) and resume persistent subscriptions in response to that event.Also, add a Kconfig configuration option to enable persistent subscriptions on nRF Connect platforms.