-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Door Lock Multi credential management test to CI. #24671
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
krypton36:AddNewDoorLockTestToCI
Feb 3, 2023
Merged
Add new Door Lock Multi credential management test to CI. #24671
bzbarsky-apple
merged 2 commits into
project-chip:master
from
krypton36:AddNewDoorLockTestToCI
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krypton36
force-pushed
the
AddNewDoorLockTestToCI
branch
from
January 26, 2023 20:32
2c6909e
to
3942c47
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 26, 2023 20:32
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
January 26, 2023 20:32
PR #24671: Size comparison from 86b064d to 3942c47 Increases above 0.2%:
Increases (18 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, esp32, psoc6)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
krypton36
force-pushed
the
AddNewDoorLockTestToCI
branch
from
January 27, 2023 22:16
2f9d06c
to
b6ebe29
Compare
PR #24671: Size comparison from 42d0ac8 to b6ebe29 Increases above 0.2%:
Increases (12 builds for bl702, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cyw30739, k32w, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
krypton36
force-pushed
the
AddNewDoorLockTestToCI
branch
from
January 30, 2023 16:25
b6ebe29
to
27e36ba
Compare
krypton36
force-pushed
the
AddNewDoorLockTestToCI
branch
from
January 30, 2023 16:25
27e36ba
to
eb07a8d
Compare
PR #24671: Size comparison from 4f24db4 to eb07a8d Increases above 0.2%:
Increases (13 builds for bl602, bl702, linux, psoc6, telink)
Decreases (2 builds for psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Feb 3, 2023
@krypton36 will this pass repl-yaml tests? |
bzbarsky-apple
approved these changes
Feb 3, 2023
@andy31415 I believe it should; there's nothing here that's particularly weird. |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ip#24671) * Add new Door Lock Multi credential management test to CI. * Update to reflect test plan PR changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding a new door lock test to validate that managing multi credential types is done to specification. Test will add unto 3 credential types if the Lock supports them by setting the according PICS value.