-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Update try_update_yaml_node_id_test_runner_state t… #24656
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_Update_try_update_yaml_node_id_test_runner_state
Jan 27, 2023
Merged
[matter_yamltests] Update try_update_yaml_node_id_test_runner_state t… #24656
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_Update_try_update_yaml_node_id_test_runner_state
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 26, 2023 15:10
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
January 26, 2023 15:10
PR #24656: Size comparison from 09ea936 to aa341b7 Increases (6 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Jan 26, 2023
tehampson
approved these changes
Jan 26, 2023
bzbarsky-apple
approved these changes
Jan 26, 2023
tehampson
reviewed
Jan 26, 2023
…o take into account WaitForCommissionee and cases where the node id should not be updated
vivien-apple
force-pushed
the
YamlTests_Update_try_update_yaml_node_id_test_runner_state
branch
from
January 27, 2023 10:15
aa341b7
to
44e730f
Compare
PR #24656: Size comparison from 4820cbd to 44e730f Increases (9 builds for bl602, cyw30739, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for bl702, esp32, nrfconnect, psoc6)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…o take into account WaitForCommissionee and cases where the node id should not be updated (project-chip#24656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o take into account WaitForCommissionee and cases where the node id should not be updated
Problem
When
DelayCommands::WaitForCommissionee
is used in the YAML tests, the node id of the used identity is not updated.Furthermore, when
DelayCommands::WaitForCommissionee
orCommissionerCommands::PairWithCode
is used but expects a failure, the node id is updated when it should not.