Add a script to simplify getting relevant zap binary if not manually installed #24651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
How about adding this to bootstrap as a check (e.g. install zap-cli if zap-cli is not available or if the version is not recent enough)? Today I've been struggling with updating my zap-cli because minimal version was bumped and I've forgotten how I've installed it on my system the last time... I forgot that the *.deb does not contain |
bzbarsky-apple
approved these changes
Jan 25, 2023
|
PR #24651: Size comparison from 0620f27 to e1019ff Increases (6 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (7 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #24651: Size comparison from 14dada3 to fdc290c Increases (3 builds for bl602, nrfconnect, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…installed (project-chip#24651) * Start writing a zap download script. Not yet functional * Restyle * Started detecting zap version to use * Added some functionality - at least zap release download seems to work * Restyle * Minimal documentation for the release download * Add support for zap development version checkout as well * Restyle * Remove some left over comments * Switch download default to project_root/.zap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may have various automated tasks needing zap-cli:
Created a script that can be invoked as:
and it downloads/sets up the given zap and also outputs the environment variable that needs to be set for the downloaded zap to be used. Not yet used in scripts, however expected longer term possible usage is that logging goes to stderr and shell scripts can eval stdout.