-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add a SpecDefinitionsFromPath helper instead of du… #24612
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_SpecDefinitionsFromPath_helper
Jan 24, 2023
Merged
[matter_yamltests] Add a SpecDefinitionsFromPath helper instead of du… #24612
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_SpecDefinitionsFromPath_helper
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
YamlTests_SpecDefinitionsFromPath_helper
branch
from
January 24, 2023 10:34
c14d977
to
cee6d6c
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
January 24, 2023 10:34
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
January 24, 2023 10:34
PR #24612: Size comparison from d15be4c to cee6d6c Increases (4 builds for bl602, cc13x2_26x2, telink)
Decreases (11 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 24, 2023
tehampson
reviewed
Jan 24, 2023
tehampson
approved these changes
Jan 24, 2023
vivien-apple
force-pushed
the
YamlTests_SpecDefinitionsFromPath_helper
branch
from
January 24, 2023 14:44
cee6d6c
to
828fccd
Compare
PR #24612: Size comparison from 7c17463 to 828fccd Increases (6 builds for cc13x2_26x2, esp32, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
YamlTests_SpecDefinitionsFromPath_helper
branch
from
January 24, 2023 16:37
d6c6b99
to
54e7a8f
Compare
PR #24612: Size comparison from 95c1888 to 54e7a8f Increases (7 builds for cc13x2_26x2, psoc6, qpg, telink)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
YamlTests_SpecDefinitionsFromPath_helper
branch
from
January 24, 2023 17:27
54e7a8f
to
bf14cde
Compare
vivien-apple
force-pushed
the
YamlTests_SpecDefinitionsFromPath_helper
branch
from
January 24, 2023 17:27
bf14cde
to
54e7a8f
Compare
vivien-apple
force-pushed
the
YamlTests_SpecDefinitionsFromPath_helper
branch
from
January 24, 2023 21:11
54e7a8f
to
7d9b692
Compare
PR #24612: Size comparison from 743b9ca to 7d9b692 Increases (11 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plicating it
Problem
Using
matter_yamltests
for interfacing withchip-tool
I also need to load the spec definitions. This PR adds a reusable helper living intomatter_yamltests
instead of me having to duplicate existing code.