Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure MTRDeviceControllerStartupParams initWithParams actually copies all the fields. #24605

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Make sure MTRDeviceControllerStartupParams initWithParams actually copies all the fields. #24605

merged 1 commit into from
Jan 24, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Also fixes the error propagation in
DeviceCommissioner::OnDeviceNOCChainGeneration to not override the provided error status.

@bzbarsky-apple
Make sure MTRDeviceControllerStartupParams initWithParams actually co…
d347610 
…pies all the fields.

Also fixes the error propagation in
DeviceCommissioner::OnDeviceNOCChainGeneration to not override the provided
error status.
@github-actions
Copy link

github-actions bot commented Jan 24, 2023 •
edited
Loading

PR #24605: Size comparison from 94034c5 to d347610

Increases (7 builds for cc13x2_26x2, cyw30739, linux, telink)
platform target config section 94034c5 d347610 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183928 183936 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550766 8 0.0
.app_xip_area 432264 432272 8 0.0
linux chip-tool debug (read only) 11570721 11570865 144 0.0
.text 9428356 9428500 144 0.0
chip-tool-ipv6only arm64 (read only) 10958732 10958876 144 0.0
.text 8740612 8740756 144 0.0
tv-app debug (read only) 3314177 3314321 144 0.0
.text 2848930 2849074 144 0.0
telink all-clusters-app tlsr9518adk80d text 688798 688800 2 0.0
thermostat tlsr9518adk80d text 597936 597938 2 0.0
Decreases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
platform target config section 94034c5 d347610 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345482 -8 -0.0
.text 1022522 1022518 -4 -0.0
bl702 lighting-app bl702 (read/write) 1184951 1184935 -16 -0.0
.debug_info 40196308 40196307 -1 -0.0
.text 952354 952352 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660663 660655 -8 -0.0
.text 557448 557440 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27470496 27470495 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27026373 27026371 -2 -0.0
light cy8ckit_062s2_43012 .debug_info 22489143 22489142 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148296 -8 -0.0
.text 595404 595396 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 652104 652102 -2 -0.0
contact-sensor-app tlsr9518adk80d (read/write) 869244 869236 -8 -0.0
text 582574 582572 -2 -0.0
lighting-app tlsr9518adk80d text 663180 663178 -2 -0.0
ota-requestor-app tlsr9518adk80d text 608288 608286 -2 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 94034c5 d347610 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345482 -8 -0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022518 -4 -0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053454 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184951 1184935 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549734 0 0.0
.debug_aranges 134064 134064 0 0.0
.debug_frame 491056 491056 0 0.0
.debug_info 40196308 40196307 -1 -0.0
.debug_line 5266802 5266802 0 0.0
.debug_loc 3402340 3402340 0 0.0
.debug_ranges 371936 371936 0 0.0
.debug_str 3533047 3533047 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571662 0 0.0
.symtab 173168 173168 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952354 952352 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698172 0 0.0
.debug_aranges 142288 142288 0 0.0
.debug_frame 518760 518760 0 0.0
.debug_info 44592646 44592646 0 0.0
.debug_line 5665127 5665127 0 0.0
.debug_loc 3598465 3598465 0 0.0
.debug_ranges 395640 395640 0 0.0
.debug_str 3936356 3936356 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632259 0 0.0
.symtab 191520 191520 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029342 1029342 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677223 0 0.0
(read/write) 174632 174632 0 0.0
.bss 81548 81548 0 0.0
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589440 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640711 640711 0 0.0
(read/write) 158240 158240 0 0.0
.bss 80740 80740 0 0.0
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 562964 562964 0 0.0
lock-ftd LP_CC2652R7 (read only) 674347 674347 0 0.0
(read/write) 174980 174980 0 0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597600 0 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660655 -8 -0.0
(read/write) 183928 183936 8 0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557440 -8 -0.0
pump-app LP_CC2652R7 (read only) 687379 687379 0 0.0
(read/write) 162676 162676 0 0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596504 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672811 0 0.0
(read/write) 177356 177356 0 0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585856 0 0.0
shell LP_CC2652R7 (read only) 668494 668494 0 0.0
(read/write) 185432 185432 0 0.0
.bss 83620 83620 0 0.0
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 583972 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585402 0 0.0
.app_xip_area 461420 461420 0 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589118 0 0.0
.app_xip_area 459840 459840 0 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550766 8 0.0
.app_xip_area 432264 432272 8 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974240 974240 0 0.0
.bss 147144 147144 0 0.0
.data 2196 2196 0 0.0
.text 824880 824880 0 0.0
BRD4161A+rs911x (read/write) 1037308 1037308 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853616 853616 0 0.0
BRD4187C (read/write) 1151392 1151392 0 0.0
.bss 133644 133644 0 0.0
.data 2544 2544 0 0.0
.text 990608 990608 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064932 1064932 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909712 909712 0 0.0
window-app BRD4187C (read/write) 1144108 1144108 0 0.0
.bss 135060 135060 0 0.0
.data 2568 2568 0 0.0
.text 981884 981884 0 0.0
esp32 all-clusters-app c3devkit (read only) 1041436 1041436 0 0.0
(read/write) 1515802 1515802 0 0.0
.dram0.bss 75904 75904 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 219888 219888 0 0.0
.flash.text 1041436 1041436 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093671 1093671 0 0.0
(read/write) 497475 497475 0 0.0
.dram0.bss 80952 80952 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248680 248680 0 0.0
.flash.text 1088287 1088287 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660908 0 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562324 0 0.0
light k32w0+release (read/write) 672820 672820 0 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592884 0 0.0
lock k32w0+release (read/write) 632288 632288 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551564 0 0.0
linux all-clusters-app debug (read only) 3148537 3148537 0 0.0
(read/write) 154736 154736 0 0.0
.bss 63616 63616 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283339 283339 0 0.0
.text 2679778 2679778 0 0.0
all-clusters-minimal-app debug (read only) 2960745 2960745 0 0.0
(read/write) 147952 147952 0 0.0
.bss 62752 62752 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282059 282059 0 0.0
.text 2496594 2496594 0 0.0
bridge-app debug (read only) 2524681 2524681 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138370 2138370 0 0.0
chip-tool debug (read only) 11570721 11570865 144 0.0
(read/write) 647344 647344 0 0.0
.bss 26232 26232 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 611296 611296 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 642705 642705 0 0.0
.text 9428356 9428500 144 0.0
chip-tool-ipv6only arm64 (read only) 10958732 10958876 144 0.0
(read/write) 696696 696696 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640120 640120 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 568540 568540 0 0.0
.text 8740612 8740756 144 0.0
lighting-app debug+rpc (read only) 2692129 2692129 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2284914 2284914 0 0.0
lock-app debug (read only) 2650985 2650985 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246056 246056 0 0.0
.text 2232418 2232418 0 0.0
ota-provider-app debug (read only) 2224945 2224945 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197448 197448 0 0.0
.text 1886978 1886978 0 0.0
ota-requestor-app debug (read only) 2386441 2386441 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032498 2032498 0 0.0
shell debug (read only) 2681073 2681073 0 0.0
(read/write) 139232 139232 0 0.0
.bss 59016 59016 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241490 241490 0 0.0
.text 2279138 2279138 0 0.0
thermostat-no-ble arm64 (read only) 2503556 2503556 0 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150816 0 0.0
.text 2090944 2090944 0 0.0
tv-app debug (read only) 3314177 3314321 144 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2848930 2849074 144 0.0
tv-casting-app debug (read only) 5691625 5691625 0 0.0
(read/write) 162264 162264 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 100216 100216 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 364980 364980 0 0.0
.text 5047986 5047986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463192 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1164968 0 0.0
bss 147118 147118 0 0.0
rodata 133232 133232 0 0.0
text 804400 804400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366544 0 0.0
bss 106418 106418 0 0.0
rodata 210720 210720 0 0.0
text 763568 763568 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110548 1110548 0 0.0
bss 146274 146274 0 0.0
rodata 110380 110380 0 0.0
text 773796 773796 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840944 0 0.0
(read/write) 1749972 1749972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189736 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1251027 1251027 0 0.0
.debug_aranges 111264 111264 0 0.0
.debug_frame 373660 373660 0 0.0
.debug_info 27470496 27470495 -1 -0.0
.debug_line 3766816 3766816 0 0.0
.debug_loc 3651585 3651585 0 0.0
.debug_ranges 357264 357264 0 0.0
.debug_str 3482273 3482273 0 0.0
.heap 840944 840944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575773 575773 0 0.0
.symtab 423440 423440 0 0.0
.text 1549184 1549184 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841752 0 0.0
(read/write) 1691228 1691228 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 188928 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236738 1236738 0 0.0
.debug_aranges 110528 110528 0 0.0
.debug_frame 376104 376104 0 0.0
.debug_info 27026373 27026371 -2 -0.0
.debug_line 3774972 3774972 0 0.0
.debug_loc 3634986 3634986 0 0.0
.debug_ranges 355232 355232 0 0.0
.debug_str 3467062 3467062 0 0.0
.heap 841752 841752 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536118 536118 0 0.0
.symtab 408400 408400 0 0.0
.text 1491248 1491248 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611148 1611148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1071778 0 0.0
.debug_aranges 102808 102808 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22489143 22489142 -1 -0.0
.debug_line 3339690 3339690 0 0.0
.debug_loc 3336752 3336752 0 0.0
.debug_ranges 319448 319448 0 0.0
.debug_str 3272731 3272731 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474042 0 0.0
.symtab 377600 377600 0 0.0
.text 1419360 1419360 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645212 1645212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073126 0 0.0
.debug_aranges 103192 103192 0 0.0
.debug_frame 348464 348464 0 0.0
.debug_info 22709759 22709759 0 0.0
.debug_line 3341459 3341459 0 0.0
.debug_loc 3358296 3358296 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3289138 3289138 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 476977 0 0.0
.symtab 379424 379424 0 0.0
.text 1448440 1448440 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148296 -8 -0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595396 -8 -0.0
lock-app qpg6105+debug (read/write) 1115992 1115992 0 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563088 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026616 1026616 0 0.0
bss 98552 98552 0 0.0
text 688798 688800 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964788 964788 0 0.0
bss 97696 97696 0 0.0
text 652104 652102 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869244 869236 -8 -0.0
bss 89844 89844 0 0.0
text 582574 582572 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885700 0 0.0
bss 89940 89940 0 0.0
text 597174 597174 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964044 0 0.0
bss 97996 97996 0 0.0
text 663180 663178 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899532 899532 0 0.0
bss 90888 90888 0 0.0
text 608288 608286 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 888916 0 0.0
bss 91328 91328 0 0.0
text 597936 597938 2 0.0

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) January 24, 2023 03:47
@bzbarsky-apple bzbarsky-apple merged commit d15be4c into project-chip:master Jan 24, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-params-init branch January 24, 2023 06:44
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Make sure MTRDeviceControllerStartupParams initWithParams actually co…
72e4a19 
…pies all the fields. (project-chip#24605)

Also fixes the error propagation in
DeviceCommissioner::OnDeviceNOCChainGeneration to not override the provided
error status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @msandstedt @jtung-apple