-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add wait keyword supports #24592
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_WaitKeywordSupports
Jan 24, 2023
Merged
[matter_yamltests] Add wait keyword supports #24592
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_WaitKeywordSupports
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns and
msandstedt
January 23, 2023 15:41
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 23, 2023 15:41
andy31415
reviewed
Jan 23, 2023
andy31415
reviewed
Jan 23, 2023
vivien-apple
force-pushed
the
YamlTests_WaitKeywordSupports
branch
from
January 23, 2023 16:44
063ef95
to
22c9fd1
Compare
PR #24592: Size comparison from 164d7cd to 22c9fd1 Increases (4 builds for psoc6, telink)
Decreases (6 builds for bl702, cyw30739, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 23, 2023
vivien-apple
force-pushed
the
YamlTests_WaitKeywordSupports
branch
from
January 23, 2023 18:25
22c9fd1
to
f07d839
Compare
PR #24592: Size comparison from 35ac9cf to f07d839 Increases (3 builds for esp32, telink)
Decreases (5 builds for bl702, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
wait
keyword that is used in the "simulated" yaml tests is not supported. This PR adds supports for it.