Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[matter_yamltests] Add groupId keyword support to the parser #24583

Merged
merged 2 commits into from
Jan 23, 2023
Merged

[matter_yamltests] Add groupId keyword support to the parser #24583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f66f488
[matter_yamltests] Add groupId keyword support to the parser
vivien-apple Jan 23, 2023
624870c
Update tests generated content
vivien-apple Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/py_matter_yamltests/matter_yamltests/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
'endpoint',
'identity',
'fabricFiltered',
'groupId',
'verification',
'nodeId',
'attribute',
Expand Down Expand Up @@ -198,6 +199,7 @@ def __init__(self, test: dict, config: dict, definitions: SpecDefinitions, pics_
self.label = _value_or_none(test, 'label')
self.optional = _value_or_none(test, 'optional')
self.node_id = _value_or_config(test, 'nodeId', config)
self.group_id = _value_or_config(test, 'groupId', config)
self.cluster = _value_or_config(test, 'cluster', config)
self.command = _value_or_config(test, 'command', config)
self.attribute = _value_or_none(test, 'attribute')
Expand Down Expand Up @@ -426,6 +428,10 @@ def optional(self):
def node_id(self):
return self._test.node_id

@property
def group_id(self):
return self._test.group_id

@property
def cluster(self):
return self._test.cluster
Expand Down
8 changes: 4 additions & 4 deletions src/app/tests/suites/TestGroupKeyManagementCluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,13 @@ tests:
{
FabricIndex: 1,
GroupId: 0x0103,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #3",
},
{
FabricIndex: 1,
GroupId: 0x0104,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #4",
},
]
Expand Down Expand Up @@ -320,13 +320,13 @@ tests:
{
FabricIndex: 1,
GroupId: 0x0103,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #3",
},
{
FabricIndex: 1,
GroupId: 0x0104,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #4",
},
]
Expand Down
32 changes: 32 additions & 0 deletions zzz_generated/chip-tool/zap-generated/test/Commands.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions zzz_generated/darwin-framework-tool/zap-generated/test/Commands.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.