-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency of libChipController on app-specific codegen. #24555
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:controller-remove-codegen-dep
Jan 20, 2023
Merged
Remove dependency of libChipController on app-specific codegen. #24555
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:controller-remove-codegen-dep
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the unused cluster id member from ClusterBase. * Make ClusterBase constructor public. * Use ClusterBase instead of generated cluster structs in src/controller. * Remove the CHIPClusters.h includes and codegen dependency.
…ose are not needed anymore.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 20, 2023 18:03
pullapprove
bot
requested review from
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 20, 2023 18:03
andy31415
approved these changes
Jan 20, 2023
PR #24555: Size comparison from 8517156 to dfcc034 Increases (6 builds for cc13x2_26x2, telink)
Decreases (31 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ect-chip#24555) * Remove dependency of libChipController on app-specific codegen. * Remove the unused cluster id member from ClusterBase. * Make ClusterBase constructor public. * Use ClusterBase instead of generated cluster structs in src/controller. * Remove the CHIPClusters.h includes and codegen dependency. * Revert the non-workflow changes from PR #project-chip#24539, since those are not needed anymore. * Regenerate generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused cluster id member from ClusterBase.
Make ClusterBase constructor public.
Use ClusterBase instead of generated cluster structs in src/controller.
Remove the CHIPClusters.h includes and codegen dependency.
Revert the non-workflow changes from PR #Fix xcodebuild to actually work on Darwin even without ZAP installed. #24539, since those are not needed anymore.
Fixes Building libCHIP.a via the Xcode build connector seems to involve codegen #24554
Fixes Address review comments on PR #24539 #24553