-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with chip-repl yamltest running TestClusterComplexTypes.yaml #24502
Merged
tehampson
merged 6 commits into
project-chip:master
from
tehampson:implement-busy-wait-ms-01-17
Jan 20, 2023
Merged
Fix issue with chip-repl yamltest running TestClusterComplexTypes.yaml #24502
tehampson
merged 6 commits into
project-chip:master
from
tehampson:implement-busy-wait-ms-01-17
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24502: Size comparison from 8303395 to ffb1e1d Increases (4 builds for bl602, esp32, psoc6, qpg)
Decreases (7 builds for bl702, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 19, 2023
pullapprove
bot
requested review from
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
jelderton
January 19, 2023 14:19
pullapprove
bot
requested review from
mlepage-google,
selissia,
mrjerryjohns,
tcarmelveilleux,
msandstedt,
tecimovic,
mspang,
vijs,
pjzander-signify,
xylophone21,
robszewczyk,
yunhanw-google and
saurabhst
January 19, 2023 14:19
andy31415
reviewed
Jan 19, 2023
andy31415
approved these changes
Jan 19, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
project-chip#24502) * Fix issue with chip-repl yaml test running TestClusterComplexTypes.yaml * Address PR comments * Restyle * Quick fix * Quick Fix * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: chip-repl yamltest would fail TestClusterComplexTypes.yaml for the following two reasons:
timedRequestTimeoutMs
Solution:
timedRequestTimeoutMs