-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zap] Fix version check #24487
Merged
Merged
[zap] Fix version check #24487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk and
saurabhst
January 18, 2023 12:27
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 18, 2023 12:27
bzbarsky-apple
approved these changes
Jan 18, 2023
jepenven-silabs
approved these changes
Jan 18, 2023
Damian-Nordic
force-pushed
the
zap-version
branch
from
January 18, 2023 13:31
1cdd356
to
1cb77eb
Compare
PR #24487: Size comparison from 1edcf88 to 1cb77eb Increases (5 builds for cc13x2_26x2, esp32, k32w, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, nrfconnect, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
zap_execution.py would fail when the minimum version was 2023.1.9 and installed was 2023.1.17. Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic
force-pushed
the
zap-version
branch
from
January 18, 2023 16:54
1cb77eb
to
e7682b2
Compare
andy31415
approved these changes
Jan 18, 2023
Thank you @Damian-Nordic . I had assumed versions would be like |
ReneJosefsen
approved these changes
Jan 18, 2023
PR #24487: Size comparison from 7c933bd to e7682b2 Increases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
zap_execution.py would fail when the minimum version was 2023.1.9 and installed was 2023.1.17. Signed-off-by: Damian Krolik <[email protected]> Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zap_execution.py would fail when the minimum version was 2023.1.9 and installed was 2023.1.17.