Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chip-repl yamltests runner #24478

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix chip-repl yamltests runner #24478

merged 1 commit into from
Jan 18, 2023

Conversation

tehampson
Copy link
Contributor

During one of the refactors of #24295 we broke the yamltests runner. When we commission the alpha device controller the only way for the runner to ever get that particular device controller it needs to be passed in. Since yamltests always expect a device to already be commissioned it is reasonable to expect for this value to be provided.

Now that some other PRs have also landed we are able to exit with -2 whenever a test step is not successful or a test step fails to encode.

@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

PR #24478: Size comparison from 481a6fd to d08f747

Increases (7 builds for cc13x2_26x2, psoc6, telink)
platform target config section 481a6fd d08f7477 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676547 676555 8 0.0
.text 589276 589284 8 0.0
pump-app LP_CC2652R7 (read only) 688223 688231 8 0.0
.text 597308 597316 8 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22361182 22361183 1 0.0
telink light-switch-app tlsr9518adk80d text 596064 596066 2 0.0
lighting-app tlsr9518adk80d text 661914 661916 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 897884 897892 8 0.0
text 607312 607314 2 0.0
thermostat tlsr9518adk80d text 596838 596842 4 0.0
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
platform target config section 481a6fd d08f7477 change % change
bl602 lighting-app bl602 (read/write) 1329422 1329414 -8 -0.0
.text 1016658 1016654 -4 -0.0
bl602+rpc .text 1047588 1047586 -2 -0.0
bl702 lighting-app bl702 (read/write) 1194751 1194735 -16 -0.0
.debug_info 39896897 39896896 -1 -0.0
.text 956882 956880 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174932 174924 -8 -0.0
pump-app LP_CC2652R7 (read/write) 161520 161512 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27337258 27337257 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22579588 22579587 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1026320 1026312 -8 -0.0
text 689122 689120 -2 -0.0
contact-sensor-app tlsr9518adk80d (read/write) 867604 867596 -8 -0.0
text 581600 581596 -4 -0.0
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 481a6fd d08f7477 change % change
bl602 lighting-app bl602 (read/write) 1329422 1329414 -8 -0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016658 1016654 -4 -0.0
bl602+rpc (read/write) 1374854 1374854 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047588 1047586 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1194751 1194735 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1533618 1533618 0 0.0
.debug_aranges 132752 132752 0 0.0
.debug_frame 487332 487332 0 0.0
.debug_info 39896897 39896896 -1 -0.0
.debug_line 5228812 5228812 0 0.0
.debug_loc 3395002 3395002 0 0.0
.debug_ranges 372288 372288 0 0.0
.debug_str 3508127 3508127 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115312 115312 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569474 569474 0 0.0
.symtab 172080 172080 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956882 956880 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1286851 1286851 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1681767 1681767 0 0.0
.debug_aranges 140968 140968 0 0.0
.debug_frame 514996 514996 0 0.0
.debug_info 44284840 44284840 0 0.0
.debug_line 5626539 5626539 0 0.0
.debug_loc 3590980 3590980 0 0.0
.debug_ranges 395984 395984 0 0.0
.debug_str 3911263 3911263 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129776 129776 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629925 629925 0 0.0
.symtab 190384 190384 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033716 1033716 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676547 676555 8 0.0
(read/write) 174932 174924 -8 -0.0
.bss 81172 81172 0 0.0
.data 3380 3380 0 0.0
.rodata 86955 86955 0 0.0
.text 589276 589284 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640171 640171 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 77043 77043 0 0.0
.text 562808 562808 0 0.0
lock-ftd LP_CC2652R7 (read only) 673991 673991 0 0.0
(read/write) 175016 175016 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 76015 76015 0 0.0
.text 597496 597496 0 0.0
lock-mtd LP_CC2652R7 (read only) 659579 659579 0 0.0
(read/write) 184692 184692 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 102443 102443 0 0.0
.text 556656 556656 0 0.0
pump-app LP_CC2652R7 (read only) 688223 688231 8 0.0
(read/write) 161520 161512 -8 -0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 90431 90431 0 0.0
.text 597308 597316 8 0.0
pump-controller-app LP_CC2652R7 (read only) 672251 672251 0 0.0
(read/write) 177596 177596 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86139 86139 0 0.0
.text 585632 585632 0 0.0
shell LP_CC2652R7 (read only) 667786 667786 0 0.0
(read/write) 186020 186020 0 0.0
.bss 83500 83500 0 0.0
.data 3376 3376 0 0.0
.rodata 83690 83690 0 0.0
.text 583784 583784 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585186 585186 0 0.0
.app_xip_area 461532 461532 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588910 588910 0 0.0
.app_xip_area 459960 459960 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549502 549502 0 0.0
.app_xip_area 431336 431336 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read/write) 659900 659900 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 561652 561652 0 0.0
light k32w0+release (read/write) 671424 671424 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591812 591812 0 0.0
lock k32w0+release (read/write) 631268 631268 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 550876 550876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10900452 10900452 0 0.0
(read/write) 695608 695608 0 0.0
.bss 34168 34168 0 0.0
.data 3024 3024 0 0.0
.data.rel.ro 639104 639104 0 0.0
.dynamic 560 560 0 0.0
.got 14104 14104 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 568500 568500 0 0.0
.text 8684740 8684740 0 0.0
thermostat-no-ble arm64 (read only) 2478748 2478748 0 0.0
(read/write) 143016 143016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149832 149832 0 0.0
.text 2068320 2068320 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461880 2461880 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424524 1424524 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164352 1164352 0 0.0
bss 146748 146748 0 0.0
rodata 132976 132976 0 0.0
text 804424 804424 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366008 1366008 0 0.0
bss 106048 106048 0 0.0
rodata 210460 210460 0 0.0
text 763664 763664 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110196 1110196 0 0.0
bss 145947 145947 0 0.0
rodata 110260 110260 0 0.0
text 773820 773820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842024 842024 0 0.0
(read/write) 1748748 1748748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188656 188656 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1247628 1247628 0 0.0
.debug_aranges 111248 111248 0 0.0
.debug_frame 373544 373544 0 0.0
.debug_info 27337258 27337257 -1 -0.0
.debug_line 3754288 3754288 0 0.0
.debug_loc 3643942 3643942 0 0.0
.debug_ranges 356464 356464 0 0.0
.debug_str 3465419 3465419 0 0.0
.heap 842024 842024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 576350 576350 0 0.0
.symtab 423872 423872 0 0.0
.text 0 0 0 0.0
1549040 1549040 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1690188 1690188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1233435 1233435 0 0.0
.debug_aranges 110512 110512 0 0.0
.debug_frame 375988 375988 0 0.0
.debug_info 26898827 26898827 0 0.0
.debug_line 3763077 3763077 0 0.0
.debug_loc 3627342 3627342 0 0.0
.debug_ranges 354432 354432 0 0.0
.debug_str 3450283 3450283 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536840 536840 0 0.0
.symtab 408832 408832 0 0.0
.text 1491240 1491240 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608860 1608860 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067828 1067828 0 0.0
.debug_aranges 102712 102712 0 0.0
.debug_frame 346320 346320 0 0.0
.debug_info 22361182 22361183 1 0.0
.debug_line 3328270 3328270 0 0.0
.debug_loc 3327504 3327504 0 0.0
.debug_ranges 318568 318568 0 0.0
.debug_str 3255813 3255813 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473145 473145 0 0.0
.symtab 377328 377328 0 0.0
.text 1418104 1418104 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642908 1642908 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069874 1069874 0 0.0
.debug_aranges 103096 103096 0 0.0
.debug_frame 348120 348120 0 0.0
.debug_info 22579588 22579587 -1 -0.0
.debug_line 3329365 3329365 0 0.0
.debug_loc 3349033 3349033 0 0.0
.debug_ranges 320424 320424 0 0.0
.debug_str 3271647 3271647 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475862 475862 0 0.0
.symtab 379152 379152 0 0.0
.text 1447160 1447160 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148060 1148060 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 595160 595160 0 0.0
lock-app qpg6105+debug (read/write) 1115052 1115052 0 0.0
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562148 562148 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026320 1026312 -8 -0.0
bss 98184 98184 0 0.0
text 689122 689120 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964652 964652 0 0.0
bss 97368 97368 0 0.0
text 652412 652412 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867604 867596 -8 -0.0
bss 89524 89524 0 0.0
text 581600 581596 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883912 883912 0 0.0
bss 89616 89616 0 0.0
text 596064 596066 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961884 961884 0 0.0
bss 97676 97676 0 0.0
text 661914 661916 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 897884 897892 8 0.0
bss 90568 90568 0 0.0
text 607312 607314 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887152 887152 0 0.0
bss 91004 91004 0 0.0
text 596838 596842 4 0.0

@vivien-apple vivien-apple merged commit 7ceb958 into project-chip:master Jan 18, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@tehampson
Fix chip-repl yamltests runner (project-chip#24478)
f654a25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple vivien-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tehampson @tcarmelveilleux @vivien-apple