-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Validate only the expected values for list/dict wh… #24475
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_ValidateOnlyTheExpectedValuesWhenComparedToTheReceivedValue
Jan 18, 2023
Merged
[matter_yamltests] Validate only the expected values for list/dict wh… #24475
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_ValidateOnlyTheExpectedValuesWhenComparedToTheReceivedValue
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
January 17, 2023 17:16
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 17, 2023 17:16
tehampson
approved these changes
Jan 17, 2023
PR #24475: Size comparison from 9fbcf1c to 392dbcb Increases (2 builds for bl702)
Decreases (2 builds for bl602, nrfconnect)
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
|
…en compared to the received value
vivien-apple
force-pushed
the
YamlTests_ValidateOnlyTheExpectedValuesWhenComparedToTheReceivedValue
branch
from
January 17, 2023 17:48
392dbcb
to
c536721
Compare
PR #24475: Size comparison from 59ab3ad to c536721 Increases (9 builds for bl702, cc13x2_26x2, cyw30739, esp32, qpg, telink)
Decreases (6 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…en compared to the received value (project-chip#24475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en compared to the received value
Problem
Some tests (e.g
ArmFailSafe.yaml
) the expected value contains only the value to validate and not all values that will be received.Using the
matter_yamltests
package it fails because it does a strict '==' comparison. This PR softened it.