-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Ethernet Network Diagnostics cluster XML with the spec. #24474
Merged
jmartinez-silabs
merged 4 commits into
project-chip:master
from
bzbarsky-apple:rename-ethernet-diagnostics
Jan 18, 2023
Merged
Align naming in Ethernet Network Diagnostics cluster XML with the spec. #24474
jmartinez-silabs
merged 4 commits into
project-chip:master
from
bzbarsky-apple:rename-ethernet-diagnostics
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
636d7c1
to
52b1eb0
Compare
PR #24474: Size comparison from 9fbcf1c to 52b1eb0 Increases (12 builds for bl602, bl702, psoc6, telink)
Decreases (3 builds for bl602, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
52b1eb0
to
abf9cbf
Compare
PR #24474: Size comparison from 89c6fb6 to abf9cbf Increases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
approved these changes
Jan 18, 2023
jmeg-sfy
approved these changes
Jan 18, 2023
abf9cbf
to
ead0adf
Compare
PR #24474: Size comparison from 25810a5 to ead0adf Increases (13 builds for bl702, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 18, 2023
PR #24474: Size comparison from e1cb26c to 6945746 Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (7 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jan 18, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…c. (project-chip#24474) * Align naming in Ethernet Network Diagnostics cluster XML with the spec. The spec changed in CHIP-Specifications/connectedhomeip-spec#6161 Fixes project-chip#24464 * Auto-update ZAP files from XML. * Regenerate generated code. Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec changed in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6161
Fixes #24464
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.