-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Administrator Commissioning XML with the spec again. #24473
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-administrator-commissioning
Jan 19, 2023
Merged
Align Administrator Commissioning XML with the spec again. #24473
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-administrator-commissioning
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24473: Size comparison from 9fbcf1c to 3bcd340 Increases (11 builds for bl602, bl702, psoc6, telink)
Decreases (3 builds for bl602, esp32, qpg)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-administrator-commissioning
branch
from
January 18, 2023 03:30
3bcd340
to
8b24d55
Compare
bzbarsky-apple
force-pushed
the
rename-administrator-commissioning
branch
from
January 18, 2023 03:42
8b24d55
to
3af0d5a
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
January 18, 2023 03:43
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 18, 2023 03:43
PR #24473: Size comparison from 89c6fb6 to 3af0d5a Increases (12 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
approved these changes
Jan 18, 2023
jmeg-sfy
approved these changes
Jan 18, 2023
Damian-Nordic
approved these changes
Jan 18, 2023
bzbarsky-apple
force-pushed
the
rename-administrator-commissioning
branch
from
January 18, 2023 12:05
3af0d5a
to
624b49e
Compare
PR #24473: Size comparison from 25810a5 to 624b49e Increases (12 builds for bl702, cc13x2_26x2, k32w, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-administrator-commissioning
branch
from
January 18, 2023 15:44
624b49e
to
c09e713
Compare
tcarmelveilleux
approved these changes
Jan 18, 2023
PR #24473: Size comparison from bdd823f to c09e713 Increases (14 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…hip#24473) * Align Administrator Commissioning XML with the spec again. The spec changed in CHIP-Specifications/connectedhomeip-spec#6149 Fixes project-chip#24465 * Auto-update ZAP files from the XML. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec changed in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6149
Fixes #24465
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.