-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix command id with the manufacturer code in python #24462
Merged
andy31415
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/command_id_fix
Jan 18, 2023
Merged
fix command id with the manufacturer code in python #24462
andy31415
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/command_id_fix
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24462: Size comparison from 9fbcf1c to 7b3e508 Increases (5 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
44a33ca
to
3534070
Compare
PR #24462: Size comparison from 59ab3ad to 3534070 Increases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, telink)
Decreases (9 builds for cc13x2_26x2, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 18, 2023
tehampson
approved these changes
Jan 18, 2023
bzbarsky-apple
approved these changes
Jan 18, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* fix command id with he manufaturer code in python * run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously python object py don't have the right manufacturer code in command Id, fix this issue in codegen.