-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bitmap generation support in zap for python cluster objects #24461
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/bitmap_python
Jan 19, 2023
Merged
add bitmap generation support in zap for python cluster objects #24461
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/bitmap_python
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
January 17, 2023 06:23
pullapprove
bot
requested review from
tecimovic,
vijs,
tehampson,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 17, 2023 06:23
PR #24461: Size comparison from 9fbcf1c to 8d13fad Increases (7 builds for bl602, bl702, telink)
Decreases (3 builds for bl602, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 17, 2023
PR #24461: Size comparison from 9fbcf1c to ba71567 Full report (6 builds for k32w, mbed, qpg)
|
yunhanw-google
force-pushed
the
feature/bitmap_python
branch
from
January 17, 2023 18:39
ba71567
to
58f0651
Compare
PR #24461: Size comparison from 59ab3ad to 58f0651 Increases (10 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Jan 18, 2023
tehampson
reviewed
Jan 18, 2023
yunhanw-google
force-pushed
the
feature/bitmap_python
branch
from
January 19, 2023 09:06
58f0651
to
ae32a94
Compare
PR #24461: Size comparison from 36133b1 to ae32a94 Increases (6 builds for bl702, cc13x2_26x2, telink)
Decreases (5 builds for bl602, cc13x2_26x2, k32w, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ect-chip#24461) * add bitmap generation support in zap for python cluster objects * run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we don't have bitmap generation support for python cluster objects. In this PR, we add this support