-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Update Subscribe UI update to clarify options #24460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeonghwan7
commented
Jan 17, 2023
- Make Dropbox Menu(Spinner) to clarify select options ('Keep Subscription' and 'is Fabric Filter')
* Make Dropbox Menu(Spinner) to clarify select options ('Keep Subscription' and 'is Fabric Filter')
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 17, 2023 04:05
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 17, 2023 06:00
yufengwangca
approved these changes
Jan 17, 2023
joonhaengHeo
approved these changes
Jan 17, 2023
PR #24460: Size comparison from 808b9fe to bb5a317 Increases (14 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (2 builds for cyw30739, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24460: Size comparison from 89c6fb6 to 133eaf2 Increases (6 builds for cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (4 builds for bl602, cc13x2_26x2, nrfconnect, qpg)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 26, 2023
@yufengwangca Hi, Could you merge this code? |
PR #24460: Size comparison from 655d134 to f8ff17c Increases (15 builds for bl602, bl702, cc13x2_26x2, efr32, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2, esp32)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24460: Size comparison from 238d606 to 6290040 Increases (8 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739, esp32, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…#24460) * [Android] Update Subscribe UI update to clarify options * Make Dropbox Menu(Spinner) to clarify select options ('Keep Subscription' and 'is Fabric Filter') * [Android] Handle Crash when interval is empty and modify variable name * Handle Crash when interval * modify variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.