[icd] Removed ICD related methods (former SED) from NoThreadImpl #24444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mrjerryjohns
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
pullapprove
bot
added
review - pending
and removed
examples
platform
nrf connect
labels
|
PR #24444: Size comparison from b4c2827 to d4c1add Increases (3 builds for psoc6, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (44 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
|
There are several methods related to ICD (former SED) used for setting expected communication intervals. Currently they are implemented only for Thread devices and for Wi-Fi the implementation returns unsupported feature through NoThreadImpl. Including this sleep intervals could be useful for some low power Wi-Fi modes too. Changes: * Removed methods implementation from NoThread impl. Now after enabling CHIP_DEVICE_CONFIG_ENABLE_SED (I believe it should be renamed to ICD in the future), the implementation will have to be provided by the proper platform. * Implemented methods for nrfconnect Wi-Fi platform.
kkasperczyk-no
force-pushed
the
sed_intervals_wifi
branch
from
d4c1add to
46a79b8
Compare
|
PR #24444: Size comparison from b4c2827 to 46a79b8 Increases (7 builds for esp32, nrfconnect, psoc6)
Decreases (13 builds for bl602, bl702, cyw30739, nrfconnect, psoc6, qpg, telink)
Full report (65 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 16, 2023
bzbarsky-apple
approved these changes
Jan 17, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ject-chip#24444) There are several methods related to ICD (former SED) used for setting expected communication intervals. Currently they are implemented only for Thread devices and for Wi-Fi the implementation returns unsupported feature through NoThreadImpl. Including this sleep intervals could be useful for some low power Wi-Fi modes too. Changes: * Removed methods implementation from NoThread impl. Now after enabling CHIP_DEVICE_CONFIG_ENABLE_SED (I believe it should be renamed to ICD in the future), the implementation will have to be provided by the proper platform. * Implemented methods for nrfconnect Wi-Fi platform.
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…ThreadImpl (project-chip#24444) There are several methods related to ICD (former SED) used for setting expected communication intervals. Currently they are implemented only for Thread devices and for Wi-Fi the implementation returns unsupported feature through NoThreadImpl. Including this sleep intervals could be useful for some low power Wi-Fi modes too. Changes: * Removed methods implementation from NoThread impl. Now after enabling CHIP_DEVICE_CONFIG_ENABLE_SED (I believe it should be renamed to ICD in the future), the implementation will have to be provided by the proper platform. * Implemented methods for nrfconnect Wi-Fi platform. (cherry picked from commit f234b94)
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
… from NoThreadImpl (project-chip#24444)" This reverts commit 0fb84bd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several methods related to ICD (former SED) used for setting expected communication intervals. Currently they are implemented only for Thread devices and for Wi-Fi the implementation returns unsupported feature through NoThreadImpl. Including this sleep intervals could be useful for some low power Wi-Fi modes too.
Changes: