[ICD] Add read handler callback to negociate max sub interval #24414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13 and
harsha-rajendran
Co-authored-by: Boris Zbarsky <[email protected]>
bzbarsky-apple
approved these changes
Jan 20, 2023
tcarmelveilleux
approved these changes
Jan 20, 2023
andy31415
reviewed
Jan 20, 2023
andy31415
reviewed
Jan 20, 2023
andy31415
reviewed
Jan 20, 2023
msandstedt
approved these changes
Jan 20, 2023
jtung-apple
approved these changes
Jan 20, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t-chip#24414) * add max interval negociation * generic read handler * restyle * Address PR comments * Update naming used * Update gn argument name * Add class / function comments * Add an ICD build to efr32 workflow * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address PR comments * restyle * Add fail safe checks to always have a valid maxInterval * PR comments Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a generic read handler callback to allow ICD device to change max interval to set their sleep time.
Tests
manual tests with an efr32