-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RegulatoryConfig support to AutoCommissioner for Android #24413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
January 13, 2023 19:47
pullapprove
bot
requested review from
tehampson,
vijs,
xylophone21 and
yufengwangca
January 26, 2023 03:13
PR #24413: Size comparison from 5b358b2 to cc74284 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #24413: Size comparison from 66d35fb to 54ae41b Increases (8 builds for bl702, cc13x2_26x2, esp32, mbed, psoc6, qpg, telink)
Decreases (10 builds for bl602, cc13x2_26x2, cc32xx, esp32, nrfconnect, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Feb 22, 2023
chrisdecenzo
approved these changes
Feb 23, 2023
PR #24413: Size comparison from 84c77b6 to efd3425 Full report (1 build for cc32xx)
|
yunhanw-google
approved these changes
Feb 24, 2023
PR #24413: Size comparison from 7775bec to 5ef5604 Increases (7 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CommissioningParameters has fields to support CountryCode and DeviceRegulatoryLocation, but the Android commissioner interface does not currently expose a way to set these fields. The interface has been updated to allow the commissioner to set these fields through the ControllerParams.