Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[time] Exclude LogTime function in release builds #24408

Merged
merged 1 commit into from
Jan 15, 2023
Merged

[time] Exclude LogTime function in release builds #24408

merged 1 commit into from
Jan 15, 2023

Conversation

Damian-Nordic
Copy link
Contributor

LogTime function that involves conversion of UTC time to string is built even if progress logging is disabled. Fix this not to include log strings in release binaries.

@Damian-Nordic
[time] Exclude LogTime function in release builds
e50db45 
LogTime function that involves conversion of UTC time to
string is built even if progress logging is disabled.
Fix this.

Signed-off-by: Damian Krolik <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited
Loading

PR #24408: Size comparison from 2a55f23 to e50db45

Increases above 0.2%:

platform target config section 2a55f23 e50db45 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174412 174932 520 0.3
lock-ftd LP_CC2652R7 (read/write) 174496 175024 528 0.3
shell LP_CC2652R7 (read/write) 185508 186036 528 0.3
Increases (13 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
platform target config section 2a55f23 e50db45 change % change
bl702 lighting-app bl702 .debug_info 39900395 39900397 2 0.0
.debug_line 5228552 5228553 1 0.0
.text 956870 956874 4 0.0
bl702+rpc .debug_line 5626141 5626142 1 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174412 174932 520 0.3
lock-ftd LP_CC2652R7 (read/write) 174496 175024 528 0.3
shell LP_CC2652R7 (read/write) 185508 186036 528 0.3
esp32 all-clusters-app c3devkit (read only) 1221428 1221432 4 0.0
.flash.text 1221428 1221432 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27342470 27342471 1 0.0
.debug_line 3753868 3753872 4 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26903754 26903755 1 0.0
.debug_line 3762657 3762661 4 0.0
light cy8ckit_062s2_43012 .debug_info 22365997 22365998 1 0.0
.debug_line 3327851 3327855 4 0.0
lock cy8ckit_062s2_43012 .debug_line 3328951 3328955 4 0.0
qpg lock-app qpg6105+debug (read/write) 1115028 1115036 8 0.0
.text 562124 562132 8 0.0
telink light-switch-app tlsr9518adk80d text 596040 596042 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 897860 897868 8 0.0
text 607288 607290 2 0.0
Decreases (14 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, psoc6, qpg, telink)
platform target config section 2a55f23 e50db45 change % change
bl602 lighting-app bl602 .text 1016646 1016644 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677067 676547 -520 -0.1
.rodata 87299 86955 -344 -0.4
.text 589452 589276 -176 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640691 640163 -528 -0.1
.rodata 77387 77043 -344 -0.4
.text 562984 562800 -184 -0.0
lock-ftd LP_CC2652R7 (read only) 674511 673983 -528 -0.1
.rodata 76359 76015 -344 -0.5
.text 597672 597488 -184 -0.0
shell LP_CC2652R7 (read only) 668298 667770 -528 -0.1
.rodata 84034 83690 -344 -0.4
.text 583952 583768 -184 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585674 585170 -504 -0.1
.app_xip_area 462020 461516 -504 -0.1
lock cyw930739m2evb_01 (read/write) 589398 588894 -504 -0.1
.app_xip_area 460448 459944 -504 -0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550022 549494 -528 -0.1
.app_xip_area 431856 431328 -528 -0.1
efr32 lock-app BRD4161A+wf200 (read/write) 1066792 1066280 -512 -0.0
.text 906564 906052 -512 -0.1
k32w contact k32w0+release (read/write) 660316 659804 -512 -0.1
.text 562068 561556 -512 -0.1
lock k32w0+release (read/write) 631700 631188 -512 -0.1
.text 551308 550796 -512 -0.1
psoc6 lock cy8ckit_062s2_43012 .debug_info 22584686 22584685 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1148044 1148036 -8 -0.0
.text 595144 595136 -8 -0.0
telink thermostat tlsr9518adk80d text 596816 596814 -2 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2a55f23 e50db45 change % change
bl602 lighting-app bl602 (read/write) 1329406 1329406 0 0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016646 1016644 -2 -0.0
bl602+rpc (read/write) 1374902 1374902 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047634 1047634 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1194735 1194735 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1533431 1533431 0 0.0
.debug_aranges 132656 132656 0 0.0
.debug_frame 486996 486996 0 0.0
.debug_info 39900395 39900397 2 0.0
.debug_line 5228552 5228553 1 0.0
.debug_loc 3394501 3394501 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3508116 3508116 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115312 115312 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569337 569337 0 0.0
.symtab 172016 172016 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956870 956874 4 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1286899 1286899 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1681901 1681901 0 0.0
.debug_aranges 140880 140880 0 0.0
.debug_frame 514708 514708 0 0.0
.debug_info 44286220 44286220 0 0.0
.debug_line 5626141 5626142 1 0.0
.debug_loc 3590508 3590508 0 0.0
.debug_ranges 395896 395896 0 0.0
.debug_str 3910726 3910726 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129776 129776 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629852 629852 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033764 1033764 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677067 676547 -520 -0.1
(read/write) 174412 174932 520 0.3
.bss 81172 81172 0 0.0
.data 3380 3380 0 0.0
.rodata 87299 86955 -344 -0.4
.text 589452 589276 -176 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640691 640163 -528 -0.1
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 77387 77043 -344 -0.4
.text 562984 562800 -184 -0.0
lock-ftd LP_CC2652R7 (read only) 674511 673983 -528 -0.1
(read/write) 174496 175024 528 0.3
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 76359 76015 -344 -0.5
.text 597672 597488 -184 -0.0
lock-mtd LP_CC2652R7 (read only) 659563 659563 0 0.0
(read/write) 184708 184708 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 102443 102443 0 0.0
.text 556640 556640 0 0.0
pump-app LP_CC2652R7 (read only) 688215 688215 0 0.0
(read/write) 161528 161528 0 0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 90431 90431 0 0.0
.text 597300 597300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672235 672235 0 0.0
(read/write) 177612 177612 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86139 86139 0 0.0
.text 585616 585616 0 0.0
shell LP_CC2652R7 (read only) 668298 667770 -528 -0.1
(read/write) 185508 186036 528 0.3
.bss 83500 83500 0 0.0
.data 3376 3376 0 0.0
.rodata 84034 83690 -344 -0.4
.text 583952 583768 -184 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585674 585170 -504 -0.1
.app_xip_area 462020 461516 -504 -0.1
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589398 588894 -504 -0.1
.app_xip_area 460448 459944 -504 -0.1
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550022 549494 -528 -0.1
.app_xip_area 431856 431328 -528 -0.1
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974108 974108 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 819748 819748 0 0.0
BRD4161A+rs911x (read/write) 1037256 1037256 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 848576 848576 0 0.0
BRD4187C (read/write) 1147924 1147924 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 982244 982244 0 0.0
lock-app BRD4161A+wf200 (read/write) 1066792 1066280 -512 -0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 906564 906052 -512 -0.1
window-app BRD4187C (read/write) 1140600 1140600 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 973480 973480 0 0.0
esp32 all-clusters-app c3devkit (read only) 1221428 1221432 4 0.0
(read/write) 1787114 1787114 0 0.0
.dram0.bss 75832 75832 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 245624 245624 0 0.0
.flash.text 1221428 1221432 4 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1235007 1235007 0 0.0
(read/write) 560335 560335 0 0.0
.dram0.bss 80984 80984 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 311408 311408 0 0.0
.flash.text 1229623 1229623 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 660316 659804 -512 -0.1
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 562068 561556 -512 -0.1
light k32w0+release (read/write) 671408 671408 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591796 591796 0 0.0
lock k32w0+release (read/write) 631700 631188 -512 -0.1
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 551308 550796 -512 -0.1
linux all-clusters-app debug (read only) 3124897 3124897 0 0.0
(read/write) 153104 153104 0 0.0
.bss 62496 62496 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 81704 81704 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 282571 282571 0 0.0
.text 2657426 2657426 0 0.0
all-clusters-minimal-app debug (read only) 2937145 2937145 0 0.0
(read/write) 146480 146480 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 76120 76120 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281259 281259 0 0.0
.text 2474242 2474242 0 0.0
bridge-app debug (read only) 2496569 2496569 0 0.0
(read/write) 130944 130944 0 0.0
.bss 52512 52512 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68712 68712 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212544 212544 0 0.0
.text 2112242 2112242 0 0.0
chip-tool debug (read only) 11431921 11431921 0 0.0
(read/write) 645296 645296 0 0.0
.bss 26168 26168 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 609328 609328 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 641765 641765 0 0.0
.text 9295172 9295172 0 0.0
chip-tool-ipv6only arm64 (read only) 10848196 10848196 0 0.0
(read/write) 694616 694616 0 0.0
.bss 34168 34168 0 0.0
.data 3024 3024 0 0.0
.data.rel.ro 638120 638120 0 0.0
.dynamic 560 560 0 0.0
.got 14096 14096 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 567924 567924 0 0.0
.text 8635412 8635412 0 0.0
lighting-app debug+rpc (read only) 2664033 2664033 0 0.0
(read/write) 130280 130280 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 71848 71848 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228512 228512 0 0.0
.text 2258770 2258770 0 0.0
lock-app debug (read only) 2622905 2622905 0 0.0
(read/write) 125328 125328 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 68824 68824 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244712 244712 0 0.0
.text 2206290 2206290 0 0.0
ota-provider-app debug (read only) 2196825 2196825 0 0.0
(read/write) 105072 105072 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51320 51320 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196072 196072 0 0.0
.text 1860850 1860850 0 0.0
ota-requestor-app debug (read only) 2358281 2358281 0 0.0
(read/write) 112800 112800 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 56088 56088 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202768 202768 0 0.0
.text 2006610 2006610 0 0.0
shell debug (read only) 2657529 2657529 0 0.0
(read/write) 137568 137568 0 0.0
.bss 57896 57896 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 72600 72600 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 240786 240786 0 0.0
.text 2256818 2256818 0 0.0
thermostat-no-ble arm64 (read only) 2478572 2478572 0 0.0
(read/write) 143016 143016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149848 149848 0 0.0
.text 2068128 2068128 0 0.0
tv-app debug (read only) 3286681 3286681 0 0.0
(read/write) 259344 259344 0 0.0
.bss 170776 170776 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 77952 77952 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 269464 269464 0 0.0
.text 2822866 2822866 0 0.0
tv-casting-app debug (read only) 5638521 5638521 0 0.0
(read/write) 160696 160696 0 0.0
.bss 52280 52280 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 99880 99880 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 361465 361465 0 0.0
.text 4999010 4999010 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461848 2461848 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424492 1424492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165324 1165324 0 0.0
bss 146748 146748 0 0.0
rodata 133820 133820 0 0.0
text 804548 804548 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366968 1366968 0 0.0
bss 106048 106048 0 0.0
rodata 211308 211308 0 0.0
text 763788 763788 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1111168 1111168 0 0.0
bss 145947 145947 0 0.0
rodata 111104 111104 0 0.0
text 773944 773944 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842024 842024 0 0.0
(read/write) 1748716 1748716 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188656 188656 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1247585 1247585 0 0.0
.debug_aranges 111144 111144 0 0.0
.debug_frame 373232 373232 0 0.0
.debug_info 27342470 27342471 1 0.0
.debug_line 3753868 3753872 4 0.0
.debug_loc 3643137 3643137 0 0.0
.debug_ranges 356360 356360 0 0.0
.debug_str 3465988 3465988 0 0.0
.heap 842024 842024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 576216 576216 0 0.0
.symtab 423744 423744 0 0.0
.text 1549008 1549008 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1690156 1690156 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1233392 1233392 0 0.0
.debug_aranges 110408 110408 0 0.0
.debug_frame 375676 375676 0 0.0
.debug_info 26903754 26903755 1 0.0
.debug_line 3762657 3762661 4 0.0
.debug_loc 3626537 3626537 0 0.0
.debug_ranges 354328 354328 0 0.0
.debug_str 3450852 3450852 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536706 536706 0 0.0
.symtab 408704 408704 0 0.0
.text 1491208 1491208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608844 1608844 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067785 1067785 0 0.0
.debug_aranges 102608 102608 0 0.0
.debug_frame 346008 346008 0 0.0
.debug_info 22365997 22365998 1 0.0
.debug_line 3327851 3327855 4 0.0
.debug_loc 3326717 3326717 0 0.0
.debug_ranges 318464 318464 0 0.0
.debug_str 3256384 3256384 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473013 473013 0 0.0
.symtab 377200 377200 0 0.0
.text 1418088 1418088 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642876 1642876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069831 1069831 0 0.0
.debug_aranges 102992 102992 0 0.0
.debug_frame 347808 347808 0 0.0
.debug_info 22584686 22584685 -1 -0.0
.debug_line 3328951 3328955 4 0.0
.debug_loc 3348305 3348305 0 0.0
.debug_ranges 320320 320320 0 0.0
.debug_str 3272218 3272218 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475730 475730 0 0.0
.symtab 379024 379024 0 0.0
.text 1447128 1447128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148044 1148036 -8 -0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 595144 595136 -8 -0.0
lock-app qpg6105+debug (read/write) 1115028 1115036 8 0.0
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562124 562132 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026288 1026288 0 0.0
bss 98184 98184 0 0.0
text 689096 689096 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964628 964628 0 0.0
bss 97368 97368 0 0.0
text 652386 652386 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867572 867572 0 0.0
bss 89524 89524 0 0.0
text 581572 581572 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883888 883888 0 0.0
bss 89616 89616 0 0.0
text 596040 596042 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961860 961860 0 0.0
bss 97676 97676 0 0.0
text 661888 661888 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 897860 897868 8 0.0
bss 90568 90568 0 0.0
text 607288 607290 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887128 887128 0 0.0
bss 91004 91004 0 0.0
text 596816 596814 -2 -0.0

arkq
arkq approved these changes Jan 13, 2023
View reviewed changes
src/credentials/LastKnownGoodTime.cpp Show resolved Hide resolved
@Damian-Nordic Damian-Nordic merged commit b4c2827 into project-chip:master Jan 15, 2023
@Damian-Nordic Damian-Nordic deleted the logtime branch January 15, 2023 11:21
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@Damian-Nordic
[time] Exclude LogTime function in release builds (project-chip#24408)
0e7569e 
LogTime function that involves conversion of UTC time to
string is built even if progress logging is disabled.
Fix this.

Signed-off-by: Damian Krolik <[email protected]>

Signed-off-by: Damian Krolik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@arkq arkq arkq approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Damian-Nordic @arkq @bzbarsky-apple