-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zephyr] Return false in unimplemented BLE central methods #24407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove stale definitions and costly BLE central error logs. Signed-off-by: Damian Krolik <[email protected]>
Two examples have not been fully updated and they do not compile with DFU over SMP enabled. Signed-off-by: Damian Krolik <[email protected]>
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 13, 2023 09:58
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 13, 2023 09:58
pullapprove
bot
added
review - pending
examples
platform
zephyr
and removed
examples
platform
zephyr
labels
Jan 13, 2023
PR #24407: Size comparison from 2a55f23 to 9c18f6f Increases (5 builds for cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (22 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (65 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 13, 2023
bzbarsky-apple
approved these changes
Jan 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…hip#24407) * [zephyr] BLE manager cleanup Remove stale definitions and costly BLE central error logs. Signed-off-by: Damian Krolik <[email protected]> * [nrfconnect] Fix build with DFU over SMP Two examples have not been fully updated and they do not compile with DFU over SMP enabled. Signed-off-by: Damian Krolik <[email protected]> Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…hods (project-chip#24407) * [zephyr] BLE manager cleanup Remove stale definitions and costly BLE central error logs. Signed-off-by: Damian Krolik <[email protected]> * [nrfconnect] Fix build with DFU over SMP Two examples have not been fully updated and they do not compile with DFU over SMP enabled. Signed-off-by: Damian Krolik <[email protected]> Signed-off-by: Damian Krolik <[email protected]> (cherry picked from commit 793deea)
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…tral methods (project-chip#24407)" This reverts commit d9e4e1a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__PRETTY_FUNCTION__
logs.mServiceMode == ConnectivityManager::kCHIPoBLEServiceMode_NotSupported
which cannot be true after removing public methods for setting the service mode.